Add product tags to each span if products are enabled #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077833
Total [baseline] (8.538 s) : 0, 8537771
Agent [candidate] (1.078 s) : 0, 1077658
Total [candidate] (8.552 s) : 0, 8552123
section iast
Agent [baseline] (1.212 s) : 0, 1212188
Total [baseline] (9.019 s) : 0, 9018683
Agent [candidate] (1.201 s) : 0, 1201475
Total [candidate] (9.024 s) : 0, 9024229
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1219545
Total [baseline] (9.028 s) : 0, 9028018
Agent [candidate] (1.211 s) : 0, 1210852
Total [candidate] (9.028 s) : 0, 9028112
section iast_TELEMETRY_OFF
Agent [baseline] (1.212 s) : 0, 1212106
Total [baseline] (9.025 s) : 0, 9025069
Agent [candidate] (1.197 s) : 0, 1197156
Total [candidate] (9.011 s) : 0, 9011026
gantt
title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.796 ms) : 0, 674796
BytebuddyAgent [candidate] (675.13 ms) : 0, 675130
GlobalTracer [baseline] (310.572 ms) : 0, 310572
GlobalTracer [candidate] (310.15 ms) : 0, 310150
AppSec [baseline] (49.613 ms) : 0, 49613
AppSec [candidate] (49.594 ms) : 0, 49594
Remote Config [baseline] (654.856 µs) : 0, 655
Remote Config [candidate] (662.497 µs) : 0, 662
Telemetry [baseline] (7.552 ms) : 0, 7552
Telemetry [candidate] (7.699 ms) : 0, 7699
section iast
BytebuddyAgent [baseline] (801.908 ms) : 0, 801908
BytebuddyAgent [candidate] (796.367 ms) : 0, 796367
GlobalTracer [baseline] (292.869 ms) : 0, 292869
GlobalTracer [candidate] (289.034 ms) : 0, 289034
AppSec [baseline] (52.018 ms) : 0, 52018
AppSec [candidate] (51.219 ms) : 0, 51219
IAST [baseline] (23.424 ms) : 0, 23424
IAST [candidate] (23.154 ms) : 0, 23154
Remote Config [baseline] (670.538 µs) : 0, 671
Remote Config [candidate] (557.694 µs) : 0, 558
Telemetry [baseline] (6.626 ms) : 0, 6626
Telemetry [candidate] (6.587 ms) : 0, 6587
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (805.704 ms) : 0, 805704
BytebuddyAgent [candidate] (801.73 ms) : 0, 801730
GlobalTracer [baseline] (294.72 ms) : 0, 294720
GlobalTracer [candidate] (290.795 ms) : 0, 290795
AppSec [baseline] (48.244 ms) : 0, 48244
AppSec [candidate] (52.711 ms) : 0, 52711
IAST [baseline] (27.053 ms) : 0, 27053
IAST [candidate] (23.719 ms) : 0, 23719
Remote Config [baseline] (2.147 ms) : 0, 2147
Remote Config [candidate] (576.384 µs) : 0, 576
Telemetry [baseline] (6.703 ms) : 0, 6703
Telemetry [candidate] (6.709 ms) : 0, 6709
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.594 ms) : 0, 800594
BytebuddyAgent [candidate] (792.932 ms) : 0, 792932
GlobalTracer [baseline] (293.728 ms) : 0, 293728
GlobalTracer [candidate] (288.895 ms) : 0, 288895
AppSec [baseline] (49.41 ms) : 0, 49410
AppSec [candidate] (51.76 ms) : 0, 51760
IAST [baseline] (25.687 ms) : 0, 25687
IAST [candidate] (22.019 ms) : 0, 22019
Remote Config [baseline] (600.238 µs) : 0, 600
Remote Config [candidate] (571.711 µs) : 0, 572
Telemetry [baseline] (7.3 ms) : 0, 7300
Telemetry [candidate] (6.619 ms) : 0, 6619
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089901
Total [baseline] (10.511 s) : 0, 10511351
Agent [candidate] (1.076 s) : 0, 1075782
Total [candidate] (10.449 s) : 0, 10448717
section appsec
Agent [baseline] (1.192 s) : 0, 1192327
Total [baseline] (10.461 s) : 0, 10460633
Agent [candidate] (1.193 s) : 0, 1192983
Total [candidate] (10.514 s) : 0, 10513756
section iast
Agent [baseline] (1.211 s) : 0, 1211005
Total [baseline] (10.759 s) : 0, 10758810
Agent [candidate] (1.201 s) : 0, 1201464
Total [candidate] (10.805 s) : 0, 10805033
section profiling
Agent [baseline] (1.28 s) : 0, 1279670
Total [baseline] (10.591 s) : 0, 10591232
Agent [candidate] (1.279 s) : 0, 1278838
Total [candidate] (10.639 s) : 0, 10638782
gantt
title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.644 ms) : 0, 683644
BytebuddyAgent [candidate] (674.449 ms) : 0, 674449
GlobalTracer [baseline] (313.156 ms) : 0, 313156
GlobalTracer [candidate] (309.229 ms) : 0, 309229
AppSec [baseline] (49.914 ms) : 0, 49914
AppSec [candidate] (49.401 ms) : 0, 49401
Remote Config [baseline] (666.69 µs) : 0, 667
Remote Config [candidate] (667.659 µs) : 0, 668
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.655 ms) : 0, 7655
section appsec
BytebuddyAgent [baseline] (695.922 ms) : 0, 695922
BytebuddyAgent [candidate] (698.346 ms) : 0, 698346
GlobalTracer [baseline] (293.536 ms) : 0, 293536
GlobalTracer [candidate] (292.372 ms) : 0, 292372
AppSec [baseline] (149.209 ms) : 0, 149209
AppSec [candidate] (149.936 ms) : 0, 149936
Remote Config [baseline] (617.574 µs) : 0, 618
Remote Config [candidate] (627.593 µs) : 0, 628
Telemetry [baseline] (9.122 ms) : 0, 9122
Telemetry [candidate] (7.518 ms) : 0, 7518
IAST [baseline] (19.265 ms) : 0, 19265
IAST [candidate] (19.22 ms) : 0, 19220
section iast
BytebuddyAgent [baseline] (800.48 ms) : 0, 800480
BytebuddyAgent [candidate] (795.252 ms) : 0, 795252
GlobalTracer [baseline] (292.898 ms) : 0, 292898
GlobalTracer [candidate] (288.996 ms) : 0, 288996
AppSec [baseline] (49.828 ms) : 0, 49828
AppSec [candidate] (50.508 ms) : 0, 50508
Remote Config [baseline] (591.368 µs) : 0, 591
Remote Config [candidate] (1.412 ms) : 0, 1412
Telemetry [baseline] (6.618 ms) : 0, 6618
Telemetry [candidate] (6.673 ms) : 0, 6673
IAST [baseline] (25.977 ms) : 0, 25977
IAST [candidate] (24.163 ms) : 0, 24163
section profiling
BytebuddyAgent [baseline] (683.25 ms) : 0, 683250
BytebuddyAgent [candidate] (683.449 ms) : 0, 683449
GlobalTracer [baseline] (384.11 ms) : 0, 384110
GlobalTracer [candidate] (383.197 ms) : 0, 383197
AppSec [baseline] (50.717 ms) : 0, 50717
AppSec [candidate] (50.546 ms) : 0, 50546
Remote Config [baseline] (739.695 µs) : 0, 740
Remote Config [candidate] (698.807 µs) : 0, 699
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.579 ms) : 0, 7579
ProfilingAgent [baseline] (96.304 ms) : 0, 96304
ProfilingAgent [candidate] (96.306 ms) : 0, 96306
Profiling [baseline] (96.329 ms) : 0, 96329
Profiling [candidate] (96.33 ms) : 0, 96330
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section baseline
no_agent (373.886 µs) : 353, 395
. : milestone, 374,
iast (479.823 µs) : 459, 501
. : milestone, 480,
iast_FULL (543.161 µs) : 523, 564
. : milestone, 543,
iast_GLOBAL (497.353 µs) : 476, 518
. : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (474.865 µs) : 455, 495
. : milestone, 475,
iast_INACTIVE (448.939 µs) : 429, 469
. : milestone, 449,
iast_TELEMETRY_OFF (474.432 µs) : 453, 496
. : milestone, 474,
tracing (451.378 µs) : 431, 472
. : milestone, 451,
section candidate
no_agent (374.002 µs) : 353, 395
. : milestone, 374,
iast (494.905 µs) : 474, 516
. : milestone, 495,
iast_FULL (561.902 µs) : 541, 582
. : milestone, 562,
iast_GLOBAL (514.246 µs) : 494, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (493.244 µs) : 472, 514
. : milestone, 493,
iast_INACTIVE (464.832 µs) : 444, 485
. : milestone, 465,
iast_TELEMETRY_OFF (484.972 µs) : 464, 506
. : milestone, 485,
tracing (458.0 µs) : 438, 478
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
. : milestone, 1347,
appsec (1.753 ms) : 1730, 1777
. : milestone, 1753,
appsec_no_iast (1.735 ms) : 1711, 1759
. : milestone, 1735,
iast (1.49 ms) : 1467, 1513
. : milestone, 1490,
profiling (1.574 ms) : 1548, 1600
. : milestone, 1574,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
section candidate
no_agent (1.35 ms) : 1330, 1371
. : milestone, 1350,
appsec (1.777 ms) : 1752, 1801
. : milestone, 1777,
appsec_no_iast (1.793 ms) : 1769, 1818
. : milestone, 1793,
iast (1.544 ms) : 1521, 1567
. : milestone, 1544,
profiling (1.563 ms) : 1538, 1588
. : milestone, 1563,
tracing (1.535 ms) : 1511, 1559
. : milestone, 1535,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section baseline
no_agent (15.386 s) : 15386000, 15386000
. : milestone, 15386000,
appsec (15.138 s) : 15138000, 15138000
. : milestone, 15138000,
iast (19.127 s) : 19127000, 19127000
. : milestone, 19127000,
iast_GLOBAL (17.92 s) : 17920000, 17920000
. : milestone, 17920000,
profiling (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
tracing (15.206 s) : 15206000, 15206000
. : milestone, 15206000,
section candidate
no_agent (15.441 s) : 15441000, 15441000
. : milestone, 15441000,
appsec (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
iast (18.558 s) : 18558000, 18558000
. : milestone, 18558000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
. : milestone, 17904000,
profiling (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
tracing (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~eaecb4b9ff, baseline=1.34.0-SNAPSHOT~6666f39b87
dateFormat X
axisFormat %s
section baseline
no_agent (1.451 ms) : 1439, 1462
. : milestone, 1451,
appsec (2.19 ms) : 2156, 2224
. : milestone, 2190,
iast (1.875 ms) : 1840, 1910
. : milestone, 1875,
iast_GLOBAL (1.911 ms) : 1875, 1947
. : milestone, 1911,
profiling (1.846 ms) : 1813, 1879
. : milestone, 1846,
tracing (1.818 ms) : 1786, 1849
. : milestone, 1818,
section candidate
no_agent (1.452 ms) : 1440, 1463
. : milestone, 1452,
appsec (2.21 ms) : 2177, 2244
. : milestone, 2210,
iast (1.89 ms) : 1855, 1926
. : milestone, 1890,
iast_GLOBAL (1.932 ms) : 1896, 1967
. : milestone, 1932,
profiling (2.325 ms) : 2149, 2502
. : milestone, 2325,
tracing (1.845 ms) : 1813, 1878
. : milestone, 1845,
|
ygree
reviewed
May 6, 2024
| @@ -3535,6 +3533,12 @@ public Map<String, String> getMergedSpanTags() { | |||
| public Map<String, String> getSpanTags() { | |||
| final Map<String, String> result = newHashMap(spanTags.size()); | |||
There was a problem hiding this comment.
Maybe add enough space for extra tags?
|
We had the same issue in the past for the sampling priority. If you want to minimize the data overhead but still ensuring that the intake will read that value, you can just write on first and last span of each chunk. We already do it here (same for V05) for the sampling priority. If you would like to adopt that way, you can exploit the |
@amarziali thank you for your comment! I'm a bit worried about cases when the trace gets split on the backed, can't really tell if tagging first and last will work. I'll need some time to investigate and can optimize in a follow up PR(s). |
mcculls
added a commit
that referenced
this pull request
May 8, 2024
mcculls
added a commit
that referenced
this pull request
May 8, 2024
PerfectSlayer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR is a followup to #6967.
Motivation
Adding product tags only to local root is not enough, as there's no guarantee that every trace segment received by the backend will have this tag (due to partial flushing, trace segment splitting etc). We need a simple and robust way of marking all data coming from DSM / DJM products. Adding the tag only when the product is enabled will add the overhead only for customers of this product.
Additional Notes
Jira