Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag every span with the product tag if it is enabled #7011

Merged
merged 1 commit into from
May 10, 2024
Merged

Tag every span with the product tag if it is enabled #7011

merged 1 commit into from
May 10, 2024

Conversation

kr-igor
Copy link
Contributor

@kr-igor kr-igor commented May 9, 2024

What Does This Do

This is a re-worked version of #6990 and a followup to #6967.

Motivation

Adding product tags only to local root is not enough, as there's no guarantee that every trace segment received by the backend will have this tag (due to partial flushing, trace segment splitting etc). We need a simple and robust way of marking all data coming from DSM / DJM products. Adding the tag only when the product is enabled will add the overhead only for customers of this product.

Additional Notes

Jira

@kr-igor kr-igor marked this pull request as ready for review May 9, 2024 17:50
@kr-igor kr-igor requested a review from a team as a code owner May 9, 2024 17:50
@kr-igor kr-igor requested review from mcculls and am312 May 9, 2024 17:50
@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master kr-igor/tag-spans-with-products-v2
git_commit_date 1715269097 1715273982
git_commit_sha e1d7174 60d5904
release_version 1.35.0-SNAPSHOT~e1d717457f 1.35.0-SNAPSHOT~60d590419b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715277053 1715277053
ci_job_id 508200101 508200101
ci_pipeline_id 33975347 33975347
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077799
Total [baseline] (8.566 s) : 0, 8566071
Agent [candidate] (1.077 s) : 0, 1077179
Total [candidate] (8.552 s) : 0, 8552048
section iast
Agent [baseline] (1.205 s) : 0, 1204652
Total [baseline] (9.009 s) : 0, 9008697
Agent [candidate] (1.215 s) : 0, 1214787
Total [candidate] (9.044 s) : 0, 9043657
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1201519
Total [baseline] (8.971 s) : 0, 8970550
Agent [candidate] (1.212 s) : 0, 1212170
Total [candidate] (9.033 s) : 0, 9033086
section iast_TELEMETRY_OFF
Agent [baseline] (1.209 s) : 0, 1208819
Total [baseline] (9.027 s) : 0, 9026617
Agent [candidate] (1.216 s) : 0, 1215566
Total [candidate] (9.02 s) : 0, 9020162
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.205 s 126.853 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 123.72 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.209 s 131.021 ms (12.2%)
Total tracing 8.566 s -
Total iast 9.009 s 442.626 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.971 s 404.479 ms (4.7%)
Total iast_TELEMETRY_OFF 9.027 s 460.545 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.215 s 137.608 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.212 s 134.991 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.216 s 138.387 ms (12.8%)
Total tracing 8.552 s -
Total iast 9.044 s 491.609 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.033 s 481.037 ms (5.6%)
Total iast_TELEMETRY_OFF 9.02 s 468.114 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.011 ms) : 0, 675011
BytebuddyAgent [candidate] (673.956 ms) : 0, 673956
GlobalTracer [baseline] (310.706 ms) : 0, 310706
GlobalTracer [candidate] (311.126 ms) : 0, 311126
AppSec [baseline] (49.445 ms) : 0, 49445
AppSec [candidate] (49.468 ms) : 0, 49468
Remote Config [baseline] (664.048 µs) : 0, 664
Remote Config [candidate] (653.951 µs) : 0, 654
Telemetry [baseline] (7.613 ms) : 0, 7613
Telemetry [candidate] (7.527 ms) : 0, 7527
section iast
BytebuddyAgent [baseline] (796.398 ms) : 0, 796398
BytebuddyAgent [candidate] (804.393 ms) : 0, 804393
GlobalTracer [baseline] (291.704 ms) : 0, 291704
GlobalTracer [candidate] (292.593 ms) : 0, 292593
AppSec [baseline] (52.292 ms) : 0, 52292
AppSec [candidate] (49.721 ms) : 0, 49721
Remote Config [baseline] (634.869 µs) : 0, 635
Remote Config [candidate] (2.101 ms) : 0, 2101
Telemetry [baseline] (6.706 ms) : 0, 6706
Telemetry [candidate] (6.645 ms) : 0, 6645
IAST [baseline] (22.582 ms) : 0, 22582
IAST [candidate] (24.479 ms) : 0, 24479
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.786 ms) : 0, 793786
BytebuddyAgent [candidate] (800.859 ms) : 0, 800859
GlobalTracer [baseline] (291.336 ms) : 0, 291336
GlobalTracer [candidate] (293.369 ms) : 0, 293369
AppSec [baseline] (50.357 ms) : 0, 50357
AppSec [candidate] (53.028 ms) : 0, 53028
Remote Config [baseline] (594.806 µs) : 0, 595
Remote Config [candidate] (597.105 µs) : 0, 597
Telemetry [baseline] (6.672 ms) : 0, 6672
Telemetry [candidate] (6.715 ms) : 0, 6715
IAST [baseline] (24.552 ms) : 0, 24552
IAST [candidate] (23.009 ms) : 0, 23009
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.947 ms) : 0, 798947
BytebuddyAgent [candidate] (806.153 ms) : 0, 806153
GlobalTracer [baseline] (293.065 ms) : 0, 293065
GlobalTracer [candidate] (292.493 ms) : 0, 292493
AppSec [baseline] (50.153 ms) : 0, 50153
AppSec [candidate] (49.662 ms) : 0, 49662
Remote Config [baseline] (608.233 µs) : 0, 608
Remote Config [candidate] (586.884 µs) : 0, 587
Telemetry [baseline] (7.309 ms) : 0, 7309
Telemetry [candidate] (6.471 ms) : 0, 6471
IAST [baseline] (24.154 ms) : 0, 24154
IAST [candidate] (25.237 ms) : 0, 25237
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090200
Total [baseline] (10.522 s) : 0, 10522368
Agent [candidate] (1.079 s) : 0, 1079321
Total [candidate] (10.396 s) : 0, 10396076
section appsec
Agent [baseline] (1.193 s) : 0, 1193094
Total [baseline] (10.472 s) : 0, 10471931
Agent [candidate] (1.191 s) : 0, 1191464
Total [candidate] (10.502 s) : 0, 10502278
section iast
Agent [baseline] (1.213 s) : 0, 1212526
Total [baseline] (10.805 s) : 0, 10805386
Agent [candidate] (1.21 s) : 0, 1209874
Total [candidate] (10.735 s) : 0, 10735490
section profiling
Agent [baseline] (1.287 s) : 0, 1286520
Total [baseline] (10.714 s) : 0, 10713781
Agent [candidate] (1.272 s) : 0, 1272150
Total [candidate] (10.7 s) : 0, 10699817
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent appsec 1.193 s 102.894 ms (9.4%)
Agent iast 1.213 s 122.326 ms (11.2%)
Agent profiling 1.287 s 196.32 ms (18.0%)
Total tracing 10.522 s -
Total appsec 10.472 s -50.437 ms (-0.5%)
Total iast 10.805 s 283.018 ms (2.7%)
Total profiling 10.714 s 191.413 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.191 s 112.143 ms (10.4%)
Agent iast 1.21 s 130.553 ms (12.1%)
Agent profiling 1.272 s 192.83 ms (17.9%)
Total tracing 10.396 s -
Total appsec 10.502 s 106.202 ms (1.0%)
Total iast 10.735 s 339.414 ms (3.3%)
Total profiling 10.7 s 303.741 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.766 ms) : 0, 680766
BytebuddyAgent [candidate] (675.415 ms) : 0, 675415
GlobalTracer [baseline] (316.358 ms) : 0, 316358
GlobalTracer [candidate] (311.827 ms) : 0, 311827
AppSec [baseline] (50.029 ms) : 0, 50029
AppSec [candidate] (49.482 ms) : 0, 49482
Remote Config [baseline] (670.562 µs) : 0, 671
Remote Config [candidate] (666.444 µs) : 0, 666
Telemetry [baseline] (7.672 ms) : 0, 7672
Telemetry [candidate] (7.603 ms) : 0, 7603
section appsec
BytebuddyAgent [baseline] (696.857 ms) : 0, 696857
BytebuddyAgent [candidate] (696.509 ms) : 0, 696509
GlobalTracer [baseline] (293.202 ms) : 0, 293202
GlobalTracer [candidate] (293.699 ms) : 0, 293699
AppSec [baseline] (149.271 ms) : 0, 149271
AppSec [candidate] (148.804 ms) : 0, 148804
Remote Config [baseline] (616.614 µs) : 0, 617
Remote Config [candidate] (615.176 µs) : 0, 615
Telemetry [baseline] (9.099 ms) : 0, 9099
Telemetry [candidate] (7.811 ms) : 0, 7811
IAST [baseline] (19.299 ms) : 0, 19299
IAST [candidate] (19.276 ms) : 0, 19276
section iast
BytebuddyAgent [baseline] (801.365 ms) : 0, 801365
BytebuddyAgent [candidate] (800.829 ms) : 0, 800829
GlobalTracer [baseline] (293.016 ms) : 0, 293016
GlobalTracer [candidate] (292.235 ms) : 0, 292235
AppSec [baseline] (49.349 ms) : 0, 49349
AppSec [candidate] (48.316 ms) : 0, 48316
Remote Config [baseline] (677.885 µs) : 0, 678
Remote Config [candidate] (1.309 ms) : 0, 1309
Telemetry [baseline] (7.429 ms) : 0, 7429
Telemetry [candidate] (7.341 ms) : 0, 7341
IAST [baseline] (25.992 ms) : 0, 25992
IAST [candidate] (25.133 ms) : 0, 25133
section profiling
ProfilingAgent [baseline] (96.866 ms) : 0, 96866
ProfilingAgent [candidate] (96.303 ms) : 0, 96303
BytebuddyAgent [baseline] (687.948 ms) : 0, 687948
BytebuddyAgent [candidate] (678.765 ms) : 0, 678765
GlobalTracer [baseline] (385.348 ms) : 0, 385348
GlobalTracer [candidate] (382.058 ms) : 0, 382058
AppSec [baseline] (50.831 ms) : 0, 50831
AppSec [candidate] (50.267 ms) : 0, 50267
Remote Config [baseline] (733.416 µs) : 0, 733
Remote Config [candidate] (704.695 µs) : 0, 705
Telemetry [baseline] (7.563 ms) : 0, 7563
Telemetry [candidate] (7.494 ms) : 0, 7494
Profiling [baseline] (96.891 ms) : 0, 96891
Profiling [candidate] (96.328 ms) : 0, 96328

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-09T17:21:36 2024-05-09T17:28:23
git_branch master kr-igor/tag-spans-with-products-v2
git_commit_date 1715269097 1715273982
git_commit_sha e1d7174 60d5904
release_version 1.35.0-SNAPSHOT~e1d717457f 1.35.0-SNAPSHOT~60d590419b
start_time 2024-05-09T17:21:23 2024-05-09T17:28:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715276044 1715276044
ci_job_id 508200102 508200102
ci_pipeline_id 33975347 33975347
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.469 µs) : 348, 387
.   : milestone, 367,
iast (471.352 µs) : 450, 492
.   : milestone, 471,
iast_FULL (531.934 µs) : 511, 553
.   : milestone, 532,
iast_GLOBAL (483.7 µs) : 463, 504
.   : milestone, 484,
iast_HARDCODED_SECRET_DISABLED (465.522 µs) : 445, 486
.   : milestone, 466,
iast_INACTIVE (439.748 µs) : 418, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (460.092 µs) : 439, 481
.   : milestone, 460,
tracing (439.862 µs) : 419, 461
.   : milestone, 440,
section candidate
no_agent (372.79 µs) : 351, 394
.   : milestone, 373,
iast (472.574 µs) : 451, 494
.   : milestone, 473,
iast_FULL (535.173 µs) : 515, 556
.   : milestone, 535,
iast_GLOBAL (493.24 µs) : 472, 515
.   : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (463.235 µs) : 443, 484
.   : milestone, 463,
iast_INACTIVE (442.082 µs) : 422, 462
.   : milestone, 442,
iast_TELEMETRY_OFF (461.46 µs) : 441, 482
.   : milestone, 461,
tracing (440.256 µs) : 420, 461
.   : milestone, 440,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.469 µs [348.07 µs, 386.868 µs] -
iast 471.352 µs [450.262 µs, 492.441 µs] 103.883 µs (28.3%)
iast_FULL 531.934 µs [511.262 µs, 552.606 µs] 164.465 µs (44.8%)
iast_GLOBAL 483.7 µs [463.171 µs, 504.228 µs] 116.231 µs (31.6%)
iast_HARDCODED_SECRET_DISABLED 465.522 µs [444.735 µs, 486.308 µs] 98.053 µs (26.7%)
iast_INACTIVE 439.748 µs [418.425 µs, 461.071 µs] 72.279 µs (19.7%)
iast_TELEMETRY_OFF 460.092 µs [438.931 µs, 481.252 µs] 92.623 µs (25.2%)
tracing 439.862 µs [418.965 µs, 460.759 µs] 72.393 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.79 µs [351.393 µs, 394.187 µs] -
iast 472.574 µs [451.402 µs, 493.746 µs] 99.784 µs (26.8%)
iast_FULL 535.173 µs [514.503 µs, 555.844 µs] 162.383 µs (43.6%)
iast_GLOBAL 493.24 µs [471.803 µs, 514.678 µs] 120.45 µs (32.3%)
iast_HARDCODED_SECRET_DISABLED 463.235 µs [442.632 µs, 483.838 µs] 90.445 µs (24.3%)
iast_INACTIVE 442.082 µs [421.769 µs, 462.396 µs] 69.292 µs (18.6%)
iast_TELEMETRY_OFF 461.46 µs [440.553 µs, 482.367 µs] 88.67 µs (23.8%)
tracing 440.256 µs [419.637 µs, 460.876 µs] 67.466 µs (18.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1378
.   : milestone, 1359,
appsec (1.692 ms) : 1668, 1716
.   : milestone, 1692,
appsec_no_iast (1.72 ms) : 1696, 1743
.   : milestone, 1720,
iast (1.486 ms) : 1463, 1508
.   : milestone, 1486,
profiling (1.496 ms) : 1471, 1521
.   : milestone, 1496,
tracing (1.469 ms) : 1444, 1494
.   : milestone, 1469,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.689 ms) : 1664, 1713
.   : milestone, 1689,
appsec_no_iast (1.681 ms) : 1656, 1705
.   : milestone, 1681,
iast (1.461 ms) : 1438, 1484
.   : milestone, 1461,
profiling (1.498 ms) : 1471, 1525
.   : milestone, 1498,
tracing (1.467 ms) : 1443, 1491
.   : milestone, 1467,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.339 ms, 1.378 ms] -
appsec 1.692 ms [1.668 ms, 1.716 ms] 333.46 µs (24.5%)
appsec_no_iast 1.72 ms [1.696 ms, 1.743 ms] 361.113 µs (26.6%)
iast 1.486 ms [1.463 ms, 1.508 ms] 127.075 µs (9.4%)
profiling 1.496 ms [1.471 ms, 1.521 ms] 137.283 µs (10.1%)
tracing 1.469 ms [1.444 ms, 1.494 ms] 110.382 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.689 ms [1.664 ms, 1.713 ms] 345.927 µs (25.8%)
appsec_no_iast 1.681 ms [1.656 ms, 1.705 ms] 338.205 µs (25.2%)
iast 1.461 ms [1.438 ms, 1.484 ms] 118.229 µs (8.8%)
profiling 1.498 ms [1.471 ms, 1.525 ms] 155.366 µs (11.6%)
tracing 1.467 ms [1.443 ms, 1.491 ms] 124.427 µs (9.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master kr-igor/tag-spans-with-products-v2
git_commit_date 1715269097 1715273982
git_commit_sha e1d7174 60d5904
release_version 1.35.0-SNAPSHOT~e1d717457f 1.35.0-SNAPSHOT~60d590419b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715276567 1715276567
ci_job_id 508200103 508200103
ci_pipeline_id 33975347 33975347
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.165 s) : 15165000, 15165000
.   : milestone, 15165000,
appsec (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
iast (18.798 s) : 18798000, 18798000
.   : milestone, 18798000,
iast_GLOBAL (17.862 s) : 17862000, 17862000
.   : milestone, 17862000,
profiling (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
tracing (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
.   : milestone, 15457000,
appsec (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
iast (18.669 s) : 18669000, 18669000
.   : milestone, 18669000,
iast_GLOBAL (18.079 s) : 18079000, 18079000
.   : milestone, 18079000,
profiling (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
tracing (14.858 s) : 14858000, 14858000
.   : milestone, 14858000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.165 s [15.165 s, 15.165 s] -
appsec 15.049 s [15.049 s, 15.049 s] -116.0 ms (-0.8%)
iast 18.798 s [18.798 s, 18.798 s] 3.633 s (24.0%)
iast_GLOBAL 17.862 s [17.862 s, 17.862 s] 2.697 s (17.8%)
profiling 15.105 s [15.105 s, 15.105 s] -60.0 ms (-0.4%)
tracing 15.095 s [15.095 s, 15.095 s] -70.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.457 s [15.457 s, 15.457 s] -
appsec 14.951 s [14.951 s, 14.951 s] -506.0 ms (-3.3%)
iast 18.669 s [18.669 s, 18.669 s] 3.212 s (20.8%)
iast_GLOBAL 18.079 s [18.079 s, 18.079 s] 2.622 s (17.0%)
profiling 15.438 s [15.438 s, 15.438 s] -19.0 ms (-0.1%)
tracing 14.858 s [14.858 s, 14.858 s] -599.0 ms (-3.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~60d590419b, baseline=1.35.0-SNAPSHOT~e1d717457f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.191 ms) : 2157, 2225
.   : milestone, 2191,
iast (1.861 ms) : 1827, 1896
.   : milestone, 1861,
iast_GLOBAL (1.913 ms) : 1878, 1948
.   : milestone, 1913,
profiling (1.831 ms) : 1798, 1864
.   : milestone, 1831,
tracing (1.818 ms) : 1786, 1850
.   : milestone, 1818,
section candidate
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.184 ms) : 2150, 2218
.   : milestone, 2184,
iast (1.862 ms) : 1828, 1897
.   : milestone, 1862,
iast_GLOBAL (1.914 ms) : 1878, 1949
.   : milestone, 1914,
profiling (1.827 ms) : 1794, 1861
.   : milestone, 1827,
tracing (1.823 ms) : 1791, 1854
.   : milestone, 1823,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.191 ms [2.157 ms, 2.225 ms] 731.939 µs (50.2%)
iast 1.861 ms [1.827 ms, 1.896 ms] 401.958 µs (27.5%)
iast_GLOBAL 1.913 ms [1.878 ms, 1.948 ms] 453.316 µs (31.1%)
profiling 1.831 ms [1.798 ms, 1.864 ms] 371.675 µs (25.5%)
tracing 1.818 ms [1.786 ms, 1.85 ms] 358.769 µs (24.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.466 ms] -
appsec 2.184 ms [2.15 ms, 2.218 ms] 728.663 µs (50.1%)
iast 1.862 ms [1.828 ms, 1.897 ms] 407.201 µs (28.0%)
iast_GLOBAL 1.914 ms [1.878 ms, 1.949 ms] 458.664 µs (31.5%)
profiling 1.827 ms [1.794 ms, 1.861 ms] 372.32 µs (25.6%)
tracing 1.823 ms [1.791 ms, 1.854 ms] 367.732 µs (25.3%)

@kr-igor kr-igor merged commit 2c0b180 into master May 10, 2024
82 checks passed
@kr-igor kr-igor deleted the kr-igor/tag-spans-with-products-v2 branch May 10, 2024 16:46
@github-actions github-actions bot added this to the 1.35.0 milestone May 10, 2024
@amarziali amarziali added the comp: data streams Data Streams Monitoring label Jun 5, 2024
@PerfectSlayer PerfectSlayer changed the title [DSM] - Tag every span with the product tag if it is enabled Tag every span with the product tag if it is enabled Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: data streams Data Streams Monitoring
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kr-igor @mcculls @amarziali