Make context injector init thread local on class change #7402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luneo7
changed the title
luneo7
force-pushed
the
context-store-injector
branch
from
58139d1
to
24a211b
Compare
luneo7
changed the title
luneo7
force-pushed
the
context-store-injector
branch
from
24a211b
to
9f3dbad
Compare
|
I'd prefer to merge #7403 because it avoids adding a thread-local |
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Make context injector init thread local on class change
Motivation
Adds a safeguard for the class being injected, since a thread can handle multiple injections and a
visitEndmight not be triggered in all cases to clean the threadlocals