Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresolved field error when instrumenting Kafka 3.7 with Quarkus native #7403

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix unresolved field error when instrumenting Kafka 3.7 with Quarkus native #7403

merged 1 commit into from
Aug 9, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Aug 9, 2024 •
edited by jira bot
Loading

What Does This Do

When an instrumentation fails the visitEnd method in FieldBackedContextInjector may not be called. This method is responsible for removing a thread local which collects the store ids injected so far, across all field-injectors of a class.

If the thread-local is not removed then collected store ids may leak across to another class, leading to getters/setters referring to a non-existent field. This doesn't cause an issue with most JVMs because that particular generated branch will never be called (since the class is not expected to hold that store). But it leads to an unresolved field on GraalVM/Quarkus because the native-image builder performs additional checks that fields exist.

Additional Notes

The instrumentation failure in Kafka 3.7 that exposed this bug was:

java.lang.IllegalStateException: Cannot locate field named metadata for class org.apache.kafka.clients.consumer.KafkaConsumer

This will be fixed in a separate PR.

Jira ticket: APMS-12871

@mcculls @luneo7
Avoid collected store ids from leaking to later field-injections when…
65a61a8 
… an instrumentation fails

Co-authored-by: luneo7 <luneo7@gmail.com>
@mcculls mcculls added the comp: native-image GraalVM native-image label Aug 9, 2024
This was referenced Aug 9, 2024
Closed
Closed
@mcculls mcculls marked this pull request as ready for review August 9, 2024 00:49
@mcculls mcculls requested a review from a team as a code owner August 9, 2024 00:49
@pr-commenter
Copy link

pr-commenter bot commented Aug 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-field-injection-leak
git_commit_date 1723137935 1723161833
git_commit_sha bec85d9 65a61a8
release_version 1.39.0-SNAPSHOT~bec85d9b82 1.39.0-SNAPSHOT~65a61a8fa9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723164757 1723164757
ci_job_id 599674969 599674969
ci_pipeline_id 41297451 41297451
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045075
Total [baseline] (8.472 s) : 0, 8471660
Agent [candidate] (1.048 s) : 0, 1048001
Total [candidate] (8.502 s) : 0, 8502464
section iast
Agent [baseline] (1.176 s) : 0, 1176455
Total [baseline] (8.952 s) : 0, 8952297
Agent [candidate] (1.178 s) : 0, 1178167
Total [candidate] (9.081 s) : 0, 9080528
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1175001
Total [baseline] (8.929 s) : 0, 8929051
Agent [candidate] (1.181 s) : 0, 1181119
Total [candidate] (8.951 s) : 0, 8951045
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1173998
Total [baseline] (8.947 s) : 0, 8946930
Agent [candidate] (1.173 s) : 0, 1172697
Total [candidate] (8.965 s) : 0, 8965393
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.176 s 131.381 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 129.926 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.174 s 128.923 ms (12.3%)
Total tracing 8.472 s -
Total iast 8.952 s 480.637 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.929 s 457.391 ms (5.4%)
Total iast_TELEMETRY_OFF 8.947 s 475.27 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.178 s 130.166 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 133.118 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.173 s 124.696 ms (11.9%)
Total tracing 8.502 s -
Total iast 9.081 s 578.063 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.951 s 448.58 ms (5.3%)
Total iast_TELEMETRY_OFF 8.965 s 462.929 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.019 ms) : 0, 667019
BytebuddyAgent [candidate] (670.35 ms) : 0, 670350
GlobalTracer [baseline] (306.252 ms) : 0, 306252
GlobalTracer [candidate] (305.688 ms) : 0, 305688
AppSec [baseline] (50.411 ms) : 0, 50411
AppSec [candidate] (50.45 ms) : 0, 50450
Remote Config [baseline] (682.779 µs) : 0, 683
Remote Config [candidate] (695.745 µs) : 0, 696
Telemetry [baseline] (7.295 ms) : 0, 7295
Telemetry [candidate] (7.331 ms) : 0, 7331
section iast
BytebuddyAgent [baseline] (783.026 ms) : 0, 783026
BytebuddyAgent [candidate] (782.763 ms) : 0, 782763
GlobalTracer [baseline] (296.581 ms) : 0, 296581
GlobalTracer [candidate] (298.512 ms) : 0, 298512
AppSec [baseline] (51.602 ms) : 0, 51602
AppSec [candidate] (52.517 ms) : 0, 52517
IAST [baseline] (22.57 ms) : 0, 22570
IAST [candidate] (22.57 ms) : 0, 22570
Remote Config [baseline] (575.485 µs) : 0, 575
Remote Config [candidate] (575.031 µs) : 0, 575
Telemetry [baseline] (8.632 ms) : 0, 8632
Telemetry [candidate] (7.754 ms) : 0, 7754
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.404 ms) : 0, 782404
BytebuddyAgent [candidate] (786.655 ms) : 0, 786655
GlobalTracer [baseline] (296.387 ms) : 0, 296387
GlobalTracer [candidate] (298.047 ms) : 0, 298047
AppSec [baseline] (51.096 ms) : 0, 51096
AppSec [candidate] (49.991 ms) : 0, 49991
IAST [baseline] (23.318 ms) : 0, 23318
IAST [candidate] (23.647 ms) : 0, 23647
Remote Config [baseline] (573.333 µs) : 0, 573
Remote Config [candidate] (591.16 µs) : 0, 591
Telemetry [baseline] (7.728 ms) : 0, 7728
Telemetry [candidate] (8.586 ms) : 0, 8586
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.751 ms) : 0, 781751
BytebuddyAgent [candidate] (779.812 ms) : 0, 779812
GlobalTracer [baseline] (297.215 ms) : 0, 297215
GlobalTracer [candidate] (297.049 ms) : 0, 297049
AppSec [baseline] (48.669 ms) : 0, 48669
AppSec [candidate] (48.268 ms) : 0, 48268
IAST [baseline] (25.221 ms) : 0, 25221
IAST [candidate] (25.792 ms) : 0, 25792
Remote Config [baseline] (630.025 µs) : 0, 630
Remote Config [candidate] (597.021 µs) : 0, 597
Telemetry [baseline] (6.996 ms) : 0, 6996
Telemetry [candidate] (7.645 ms) : 0, 7645
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046738
Total [baseline] (10.367 s) : 0, 10366509
Agent [candidate] (1.048 s) : 0, 1048136
Total [candidate] (10.272 s) : 0, 10271541
section appsec
Agent [baseline] (1.172 s) : 0, 1172011
Total [baseline] (10.448 s) : 0, 10448316
Agent [candidate] (1.165 s) : 0, 1164921
Total [candidate] (10.516 s) : 0, 10515787
section iast
Agent [baseline] (1.177 s) : 0, 1177146
Total [baseline] (10.803 s) : 0, 10802726
Agent [candidate] (1.173 s) : 0, 1172810
Total [candidate] (10.748 s) : 0, 10748424
section profiling
Agent [baseline] (1.245 s) : 0, 1245274
Total [baseline] (10.548 s) : 0, 10547829
Agent [candidate] (1.243 s) : 0, 1242546
Total [candidate] (10.531 s) : 0, 10530531
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.172 s 125.273 ms (12.0%)
Agent iast 1.177 s 130.408 ms (12.5%)
Agent profiling 1.245 s 198.536 ms (19.0%)
Total tracing 10.367 s -
Total appsec 10.448 s 81.806 ms (0.8%)
Total iast 10.803 s 436.217 ms (4.2%)
Total profiling 10.548 s 181.319 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.165 s 116.785 ms (11.1%)
Agent iast 1.173 s 124.674 ms (11.9%)
Agent profiling 1.243 s 194.41 ms (18.5%)
Total tracing 10.272 s -
Total appsec 10.516 s 244.245 ms (2.4%)
Total iast 10.748 s 476.883 ms (4.6%)
Total profiling 10.531 s 258.99 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.163 ms) : 0, 668163
BytebuddyAgent [candidate] (668.503 ms) : 0, 668503
GlobalTracer [baseline] (306.735 ms) : 0, 306735
GlobalTracer [candidate] (307.898 ms) : 0, 307898
AppSec [baseline] (50.354 ms) : 0, 50354
AppSec [candidate] (50.252 ms) : 0, 50252
Remote Config [baseline] (691.642 µs) : 0, 692
Remote Config [candidate] (689.286 µs) : 0, 689
Telemetry [baseline] (7.364 ms) : 0, 7364
Telemetry [candidate] (7.352 ms) : 0, 7352
section appsec
BytebuddyAgent [baseline] (682.554 ms) : 0, 682554
BytebuddyAgent [candidate] (677.305 ms) : 0, 677305
GlobalTracer [baseline] (301.556 ms) : 0, 301556
GlobalTracer [candidate] (299.786 ms) : 0, 299786
AppSec [baseline] (155.357 ms) : 0, 155357
AppSec [candidate] (155.107 ms) : 0, 155107
Remote Config [baseline] (607.869 µs) : 0, 608
Remote Config [candidate] (598.957 µs) : 0, 599
Telemetry [baseline] (8.198 ms) : 0, 8198
Telemetry [candidate] (8.548 ms) : 0, 8548
IAST [baseline] (20.376 ms) : 0, 20376
IAST [candidate] (20.177 ms) : 0, 20177
section iast
BytebuddyAgent [baseline] (785.346 ms) : 0, 785346
BytebuddyAgent [candidate] (781.411 ms) : 0, 781411
GlobalTracer [baseline] (295.948 ms) : 0, 295948
GlobalTracer [candidate] (295.958 ms) : 0, 295958
AppSec [baseline] (49.063 ms) : 0, 49063
AppSec [candidate] (50.915 ms) : 0, 50915
Remote Config [baseline] (596.228 µs) : 0, 596
Remote Config [candidate] (585.566 µs) : 0, 586
Telemetry [baseline] (9.325 ms) : 0, 9325
Telemetry [candidate] (7.831 ms) : 0, 7831
IAST [baseline] (23.306 ms) : 0, 23306
IAST [candidate] (22.602 ms) : 0, 22602
section profiling
ProfilingAgent [baseline] (95.25 ms) : 0, 95250
ProfilingAgent [candidate] (94.662 ms) : 0, 94662
BytebuddyAgent [baseline] (663.631 ms) : 0, 663631
BytebuddyAgent [candidate] (662.035 ms) : 0, 662035
GlobalTracer [baseline] (389.792 ms) : 0, 389792
GlobalTracer [candidate] (389.453 ms) : 0, 389453
AppSec [baseline] (51.484 ms) : 0, 51484
AppSec [candidate] (51.293 ms) : 0, 51293
Remote Config [baseline] (685.768 µs) : 0, 686
Remote Config [candidate] (709.147 µs) : 0, 709
Telemetry [baseline] (7.243 ms) : 0, 7243
Telemetry [candidate] (7.219 ms) : 0, 7219
Profiling [baseline] (95.276 ms) : 0, 95276
Profiling [candidate] (94.687 ms) : 0, 94687
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-09T00:23:25 2024-08-09T00:30:12
git_branch master mcculls/avoid-field-injection-leak
git_commit_date 1723137935 1723161833
git_commit_sha bec85d9 65a61a8
release_version 1.39.0-SNAPSHOT~bec85d9b82 1.39.0-SNAPSHOT~65a61a8fa9
start_time 2024-08-09T00:23:11 2024-08-09T00:29:59
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723163758 1723163758
ci_job_id 599674970 599674970
ci_pipeline_id 41297451 41297451
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1320, 1359
.   : milestone, 1340,
appsec (1.696 ms) : 1673, 1719
.   : milestone, 1696,
appsec_no_iast (1.724 ms) : 1700, 1749
.   : milestone, 1724,
iast (1.473 ms) : 1450, 1495
.   : milestone, 1473,
profiling (1.482 ms) : 1457, 1507
.   : milestone, 1482,
tracing (1.464 ms) : 1439, 1488
.   : milestone, 1464,
section candidate
no_agent (1.34 ms) : 1319, 1360
.   : milestone, 1340,
appsec (1.708 ms) : 1683, 1732
.   : milestone, 1708,
appsec_no_iast (1.715 ms) : 1692, 1739
.   : milestone, 1715,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.533 ms) : 1507, 1558
.   : milestone, 1533,
tracing (1.466 ms) : 1442, 1491
.   : milestone, 1466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.359 ms] -
appsec 1.696 ms [1.673 ms, 1.719 ms] 356.229 µs (26.6%)
appsec_no_iast 1.724 ms [1.7 ms, 1.749 ms] 384.463 µs (28.7%)
iast 1.473 ms [1.45 ms, 1.495 ms] 132.804 µs (9.9%)
profiling 1.482 ms [1.457 ms, 1.507 ms] 142.318 µs (10.6%)
tracing 1.464 ms [1.439 ms, 1.488 ms] 123.925 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.319 ms, 1.36 ms] -
appsec 1.708 ms [1.683 ms, 1.732 ms] 367.935 µs (27.5%)
appsec_no_iast 1.715 ms [1.692 ms, 1.739 ms] 375.656 µs (28.0%)
iast 1.489 ms [1.466 ms, 1.512 ms] 149.498 µs (11.2%)
profiling 1.533 ms [1.507 ms, 1.558 ms] 193.217 µs (14.4%)
tracing 1.466 ms [1.442 ms, 1.491 ms] 126.675 µs (9.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.232 µs) : 349, 389
.   : milestone, 369,
iast (478.644 µs) : 457, 500
.   : milestone, 479,
iast_FULL (548.032 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (502.934 µs) : 481, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (480.101 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (451.911 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (470.244 µs) : 449, 492
.   : milestone, 470,
tracing (439.757 µs) : 419, 460
.   : milestone, 440,
section candidate
no_agent (372.087 µs) : 353, 392
.   : milestone, 372,
iast (473.775 µs) : 453, 495
.   : milestone, 474,
iast_FULL (551.396 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (503.255 µs) : 482, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (488.666 µs) : 467, 510
.   : milestone, 489,
iast_INACTIVE (460.173 µs) : 438, 483
.   : milestone, 460,
iast_TELEMETRY_OFF (473.664 µs) : 453, 495
.   : milestone, 474,
tracing (444.562 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.232 µs [349.016 µs, 389.448 µs] -
iast 478.644 µs [457.403 µs, 499.885 µs] 109.412 µs (29.6%)
iast_FULL 548.032 µs [526.747 µs, 569.317 µs] 178.8 µs (48.4%)
iast_GLOBAL 502.934 µs [480.969 µs, 524.899 µs] 133.702 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED 480.101 µs [459.125 µs, 501.076 µs] 110.869 µs (30.0%)
iast_INACTIVE 451.911 µs [430.527 µs, 473.295 µs] 82.679 µs (22.4%)
iast_TELEMETRY_OFF 470.244 µs [448.592 µs, 491.896 µs] 101.012 µs (27.4%)
tracing 439.757 µs [419.31 µs, 460.204 µs] 70.525 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.087 µs [352.651 µs, 391.523 µs] -
iast 473.775 µs [452.545 µs, 495.006 µs] 101.688 µs (27.3%)
iast_FULL 551.396 µs [530.128 µs, 572.664 µs] 179.309 µs (48.2%)
iast_GLOBAL 503.255 µs [482.105 µs, 524.405 µs] 131.168 µs (35.3%)
iast_HARDCODED_SECRET_DISABLED 488.666 µs [467.211 µs, 510.121 µs] 116.579 µs (31.3%)
iast_INACTIVE 460.173 µs [437.785 µs, 482.561 µs] 88.086 µs (23.7%)
iast_TELEMETRY_OFF 473.664 µs [452.613 µs, 494.714 µs] 101.577 µs (27.3%)
tracing 444.562 µs [423.605 µs, 465.518 µs] 72.475 µs (19.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-field-injection-leak
git_commit_date 1723137935 1723161833
git_commit_sha bec85d9 65a61a8
release_version 1.39.0-SNAPSHOT~bec85d9b82 1.39.0-SNAPSHOT~65a61a8fa9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723164261 1723164261
ci_job_id 599674971 599674971
ci_pipeline_id 41297451 41297451
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.842 s) : 14842000, 14842000
.   : milestone, 14842000,
appsec (15.318 s) : 15318000, 15318000
.   : milestone, 15318000,
iast (18.695 s) : 18695000, 18695000
.   : milestone, 18695000,
iast_GLOBAL (17.821 s) : 17821000, 17821000
.   : milestone, 17821000,
profiling (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
tracing (14.893 s) : 14893000, 14893000
.   : milestone, 14893000,
section candidate
no_agent (15.544 s) : 15544000, 15544000
.   : milestone, 15544000,
appsec (15.176 s) : 15176000, 15176000
.   : milestone, 15176000,
iast (19.022 s) : 19022000, 19022000
.   : milestone, 19022000,
iast_GLOBAL (17.798 s) : 17798000, 17798000
.   : milestone, 17798000,
profiling (15.434 s) : 15434000, 15434000
.   : milestone, 15434000,
tracing (15.131 s) : 15131000, 15131000
.   : milestone, 15131000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.842 s [14.842 s, 14.842 s] -
appsec 15.318 s [15.318 s, 15.318 s] 476.0 ms (3.2%)
iast 18.695 s [18.695 s, 18.695 s] 3.853 s (26.0%)
iast_GLOBAL 17.821 s [17.821 s, 17.821 s] 2.979 s (20.1%)
profiling 14.995 s [14.995 s, 14.995 s] 153.0 ms (1.0%)
tracing 14.893 s [14.893 s, 14.893 s] 51.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.544 s [15.544 s, 15.544 s] -
appsec 15.176 s [15.176 s, 15.176 s] -368.0 ms (-2.4%)
iast 19.022 s [19.022 s, 19.022 s] 3.478 s (22.4%)
iast_GLOBAL 17.798 s [17.798 s, 17.798 s] 2.254 s (14.5%)
profiling 15.434 s [15.434 s, 15.434 s] -110.0 ms (-0.7%)
tracing 15.131 s [15.131 s, 15.131 s] -413.0 ms (-2.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~65a61a8fa9, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.205 ms) : 2171, 2240
.   : milestone, 2205,
iast (1.963 ms) : 1922, 2005
.   : milestone, 1963,
iast_GLOBAL (2.02 ms) : 1976, 2064
.   : milestone, 2020,
profiling (1.856 ms) : 1823, 1890
.   : milestone, 1856,
tracing (1.821 ms) : 1789, 1853
.   : milestone, 1821,
section candidate
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.201 ms) : 2167, 2235
.   : milestone, 2201,
iast (1.954 ms) : 1913, 1996
.   : milestone, 1954,
iast_GLOBAL (2.011 ms) : 1970, 2053
.   : milestone, 2011,
profiling (1.858 ms) : 1824, 1893
.   : milestone, 1858,
tracing (1.839 ms) : 1806, 1872
.   : milestone, 1839,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.205 ms [2.171 ms, 2.24 ms] 746.607 µs (51.2%)
iast 1.963 ms [1.922 ms, 2.005 ms] 504.542 µs (34.6%)
iast_GLOBAL 2.02 ms [1.976 ms, 2.064 ms] 560.962 µs (38.5%)
profiling 1.856 ms [1.823 ms, 1.89 ms] 397.601 µs (27.3%)
tracing 1.821 ms [1.789 ms, 1.853 ms] 361.903 µs (24.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.201 ms [2.167 ms, 2.235 ms] 745.509 µs (51.2%)
iast 1.954 ms [1.913 ms, 1.996 ms] 498.829 µs (34.3%)
iast_GLOBAL 2.011 ms [1.97 ms, 2.053 ms] 555.891 µs (38.2%)
profiling 1.858 ms [1.824 ms, 1.893 ms] 403.073 µs (27.7%)
tracing 1.839 ms [1.806 ms, 1.872 ms] 383.484 µs (26.3%)

@mcculls mcculls enabled auto-merge (squash) August 9, 2024 01:18
@mcculls mcculls merged commit bb44d60 into master Aug 9, 2024
82 checks passed
@mcculls mcculls deleted the mcculls/avoid-field-injection-leak branch August 9, 2024 08:21
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 9, 2024
@PerfectSlayer PerfectSlayer mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@luneo7 luneo7 luneo7 approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: native-image GraalVM native-image
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @amarziali @luneo7