[test optimization] More robust cypress test (#6463)

Author: juan-fernandez

integration-tests/cypress/cypress.spec.js

@@ -120,7 +120,7 @@ moduleTypes.forEach(({
     }
 
     this.retries(2)
-    this.timeout(70000)
+    this.timeout(80000)
     let sandbox, cwd, receiver, childProcess, webAppPort, secondWebAppServer
 
     if (type === 'commonJS') {
@@ -195,21 +195,20 @@ moduleTypes.forEach(({
       })
     }
 
-    it('does not crash if badly init', (done) => {
+    it('does not crash if badly init', async () => {
       const {
         NODE_OPTIONS, // NODE_OPTIONS dd-trace config does not work with cypress
         DD_CIVISIBILITY_AGENTLESS_URL,
         ...restEnvVars
       } = getCiVisAgentlessConfig(receiver.port)
 
-      receiver.assertPayloadReceived(() => {
-        const error = new Error('it should not report test events')
-        // eslint-disable-next-line no-console
-        console.log('it should never be executed')
-        done(error)
+      let hasReceivedEvents = false
+
+      const eventsPromise = receiver.assertPayloadReceived(() => {
+        hasReceivedEvents = true
       }, ({ url }) => url.endsWith('/api/v2/citestcycle')).catch(() => {})
 
-      let testOutput
+      let testOutput = ''
 
       childProcess = exec(
         testCommand,
@@ -231,22 +230,27 @@ moduleTypes.forEach(({
         testOutput += chunk.toString()
       })
 
-      childProcess.on('exit', () => {
+      await Promise.all([
+        once(childProcess.stdout, 'end'),
+        once(childProcess.stderr, 'end'),
+        once(childProcess, 'exit'),
+        eventsPromise
+      ])
+
+      assert.strictEqual(hasReceivedEvents, false)
+      // TODO: remove try/catch once we find the source of flakiness
+      try {
         assert.notInclude(testOutput, 'TypeError')
-        // TODO: remove try/catch once we find the source of flakiness
-        try {
-          assert.include(testOutput, '1 of 1 failed')
-          done()
-        } catch (e) {
-          // eslint-disable-next-line no-console
-          console.log('---- Actual test output -----')
-          // eslint-disable-next-line no-console
-          console.log(testOutput)
-          // eslint-disable-next-line no-console
-          console.log('---- finish actual test output -----')
-          done(e)
-        }
-      })
+        assert.include(testOutput, '1 of 1 failed')
+      } catch (e) {
+        // eslint-disable-next-line no-console
+        console.log('---- Actual test output -----')
+        // eslint-disable-next-line no-console
+        console.log(testOutput)
+        // eslint-disable-next-line no-console
+        console.log('---- finish actual test output -----')
+        throw e
+      }
     })
 
     it('catches errors in hooks', (done) => {