ci: test oracledb without custom docker image (#6609)

Author: rochdev

.github/workflows/apm-integrations.yml

@@ -704,16 +704,9 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: ./.github/actions/plugins/test
 
-  # TODO: Install the Oracle client on the host and test Node >=16.
   # TODO: Figure out why nyc stopped working with EACCESS errors.
   oracledb:
     runs-on: ubuntu-latest
-    container:
-      image: bengl/node-12-with-oracle-client
-      volumes:
-        - /node20217:/node20217:rw,rshared
-        - /node20217:/__e/node20:ro,rshared
-        - /node20217:/__e/node24:ro,rshared
     services:
       oracledb:
         image: gvenzl/oracle-xe:18-slim
@@ -734,19 +727,22 @@ jobs:
     env:
       PLUGINS: oracledb
       SERVICES: oracledb
-      DD_TEST_AGENT_URL: http://testagent:9126
       DD_INJECT_FORCE: 'true'
     steps:
-      # https://github.com/actions/runner/issues/2906#issuecomment-2109514798
-      - name: Install Node for runner (with glibc 2.17 compatibility)
-        run: |
-          curl -LO https://unofficial-builds.nodejs.org/download/release/v20.19.3/node-v20.19.3-linux-x64-glibc-217.tar.xz
-          tar -xf node-v20.19.3-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: ./.github/actions/node
         with:
           version: eol
       - uses: ./.github/actions/install
+      - run: |
+          mkdir -p /opt/oracle
+          cd /opt/oracle
+          wget https://download.oracle.com/otn_software/linux/instantclient/1928000/instantclient-basic-linux.x64-19.28.0.0.0dbru.zip
+          unzip instantclient-basic-linux.x64-19.28.0.0.0dbru.zip
+          sudo apt-get update -y && sudo apt-get install -y libaio1t64
+          sudo ln -s /usr/lib/x86_64-linux-gnu/libaio.so.1t64 /usr/lib/x86_64-linux-gnu/libaio.so.1
+          sudo sh -c "echo /opt/oracle/instantclient_19_28 > /etc/ld.so.conf.d/oracle-instantclient.conf"
+          sudo ldconfig
       - run: yarn config set ignore-engines true
       - run: yarn services --ignore-engines
       - run: yarn test:plugins --ignore-engines

packages/datadog-plugin-oracledb/test/index.spec.js

@@ -10,7 +10,7 @@ const agent = require('../../dd-trace/test/plugins/agent')
 const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK } = require('../../dd-trace/src/constants')
 const { expectedSchema, rawExpectedSchema } = require('./naming')
 
-const hostname = process.env.CI ? 'oracledb' : 'localhost'
+const hostname = 'localhost'
 // TODO: Use another port or db instance to differentiate it better from defaults
 const port = '1521'
 const dbInstance = 'xepdb1'

packages/datadog-plugin-oracledb/test/integration-test/client.spec.js

@@ -41,9 +41,7 @@ describe('esm', () => {
         assert.strictEqual(checkSpansForServiceName(payload, 'oracle.query'), true)
       })
 
-      proc = await spawnPluginIntegrationTestProc(sandbox.folder, 'server.mjs', agent.port, undefined, {
-        LD_LIBRARY_PATH: '/usr/lib/oracle/18.5/client64/lib:'
-      })
+      proc = await spawnPluginIntegrationTestProc(sandbox.folder, 'server.mjs', agent.port)
 
       await res
     }).timeout(20000)

packages/datadog-plugin-oracledb/test/integration-test/server.mjs

@@ -1,7 +1,7 @@
 import 'dd-trace/init.js'
 import oracledb from 'oracledb'
 
-const hostname = 'oracledb'
+const hostname = 'localhost'
 
 const config = {
   user: 'test',

packages/dd-trace/test/setup/services/oracledb.js

@@ -3,7 +3,7 @@
 const RetryOperation = require('../operation')
 const oracledb = require('../../../../../versions/oracledb').get()
 
-const hostname = process.env.CI ? 'oracledb' : 'localhost'
+const hostname = 'localhost'
 
 function waitForOracledb () {
   return new Promise((resolve, reject) => {