Skip to content

Commit e28e38d

Browse files
tlhunterBridgeARsabrennerwconti27
authored
ci: update github actions to use node latest, not active (#6273)
- updates GitHub CI jobs to use the latest (24) Node.js instead of currently active LTS (22) - some cases already tested latest and active so I kept those the same - note that this skips Express and we'll need a follow up PR to enable it --------- Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> Co-authored-by: Sam Brenner <sam.brenner@datadoghq.com> Co-authored-by: William Conti <william.conti@datadoghq.com>
1 parent 2774e1d commit e28e38d

20 files changed

+2902
-50
lines changed

‎.github/actions/instrumentations/test/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ runs:
77
- uses: ./.github/actions/install
88
- run: yarn test:instrumentations:ci
99
shell: bash
10-
- uses: ./.github/actions/node/active-lts
10+
- uses: ./.github/actions/node/latest
1111
- run: yarn test:instrumentations:ci
1212
shell: bash
1313
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3

‎.github/actions/plugins/test-and-upstream/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ runs:
1010
shell: bash
1111
- run: yarn test:plugins:upstream
1212
shell: bash
13-
- uses: ./.github/actions/node/active-lts
13+
- uses: ./.github/actions/node/latest
1414
- run: yarn test:plugins:ci
1515
shell: bash
1616
- run: yarn test:plugins:upstream

‎.github/actions/plugins/test/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
- uses: ./.github/actions/install
99
- run: yarn test:plugins:ci
1010
shell: bash
11-
- uses: ./.github/actions/node/active-lts
11+
- uses: ./.github/actions/node/latest
1212
- run: yarn test:plugins:ci
1313
shell: bash
1414
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3

‎.github/actions/plugins/upstream/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
- uses: ./.github/actions/install
99
- run: yarn test:plugins:upstream
1010
shell: bash
11-
- uses: ./.github/actions/node/active-lts
11+
- uses: ./.github/actions/node/latest
1212
- run: yarn test:plugins:upstream
1313
shell: bash
1414
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3

‎.github/workflows/apm-capabilities.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
runs-on: macos-latest
2020
steps:
2121
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
22-
- uses: ./.github/actions/node/active-lts
22+
- uses: ./.github/actions/node/latest
2323
- uses: ./.github/actions/install
2424
- run: yarn test:trace:core:ci
2525
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
@@ -43,7 +43,7 @@ jobs:
4343
runs-on: windows-latest
4444
steps:
4545
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
46-
- uses: ./.github/actions/node/active-lts
46+
- uses: ./.github/actions/node/latest
4747
- uses: ./.github/actions/install
4848
with:
4949
cache: 'true'

‎.github/workflows/apm-integrations.yml

Lines changed: 34 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
aerospike:
5151
image: aerospike:${{ matrix.aerospike-image }}
5252
ports:
53-
- "127.0.0.1:3000-3002:3000-3002"
53+
- '127.0.0.1:3000-3002:3000-3002'
5454
env:
5555
PLUGINS: aerospike
5656
SERVICES: aerospike
@@ -172,7 +172,12 @@ jobs:
172172
strategy:
173173
matrix:
174174
# using node versions matrix since this plugin testing fails due to install differences between node versions
175-
node-version: ['18', '20', '22']
175+
node-version: [18, 20, 22]
176+
range: ['>=1.0.0']
177+
include:
178+
- node-version: 24
179+
range: '>=1.4.0'
180+
range_clean: gte.1.4.0
176181
runs-on: ubuntu-latest
177182
services:
178183
kafka:
@@ -195,6 +200,7 @@ jobs:
195200
env:
196201
PLUGINS: confluentinc-kafka-javascript
197202
SERVICES: kafka
203+
PACKAGE_VERSION_RANGE: ${{ matrix.range }}
198204
steps:
199205
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
200206
- uses: ./.github/actions/testagent/start
@@ -285,7 +291,7 @@ jobs:
285291
steps:
286292
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
287293
- uses: ./.github/actions/testagent/start
288-
- uses: ./.github/actions/node/active-lts
294+
- uses: ./.github/actions/node/latest
289295
- uses: ./.github/actions/install
290296
- run: yarn test:plugins:ci
291297
- if: always()
@@ -300,7 +306,10 @@ jobs:
300306
PLUGINS: express
301307
steps:
302308
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
303-
- uses: ./.github/actions/plugins/test
309+
- uses: ./.github/actions/testagent/start
310+
- uses: ./.github/actions/node/active-lts # TODO: change this to latest once we figure out the `fresh` bug
311+
- uses: ./.github/actions/install
312+
- run: yarn test:plugins:ci
304313

305314
fastify:
306315
runs-on: ubuntu-latest
@@ -622,7 +631,15 @@ jobs:
622631
version:
623632
- 18
624633
- latest
625-
range: ['>=10.2.0 <11', '>=11.0.0 <13', '11.1.4', '>=13.0.0 <14', '13.2.0', '>=14.0.0 <=14.2.6', '>=14.2.7 <15', '>=15.0.0 <15.4.1']
634+
range:
635+
- '>=10.2.0 <11'
636+
- '>=11.0.0 <13'
637+
- '11.1.4'
638+
- '>=13.0.0 <14'
639+
- '13.2.0'
640+
- '>=14.0.0 <=14.2.6'
641+
- '>=14.2.7 <15'
642+
- '>=15.0.0 <15.4.1'
626643
include:
627644
- range: '>=10.2.0 <11'
628645
range_clean: gte.10.2.0.and.lt.11
@@ -647,7 +664,7 @@ jobs:
647664
steps:
648665
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
649666
- uses: ./.github/actions/testagent/start
650-
- uses: ./.github/actions/node/active-lts
667+
- uses: ./.github/actions/node/latest
651668
- uses: ./.github/actions/install
652669
- run: yarn test:plugins:ci
653670
- if: always()
@@ -731,7 +748,7 @@ jobs:
731748
- uses: ./.github/actions/node/newest-maintenance-lts
732749
- uses: ./.github/actions/install
733750
- run: yarn test:plugins:ci
734-
- uses: ./.github/actions/node/active-lts
751+
- uses: ./.github/actions/node/latest
735752
- run: yarn test:plugins:ci
736753
# - run: yarn test:plugins:upstream
737754
- if: always()
@@ -823,13 +840,20 @@ jobs:
823840
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
824841
- uses: ./.github/actions/plugins/test
825842

843+
# Restify isn't compatible with Node.js v24 so we don't run against latest Node.js
844+
# see: https://github.com/restify/node-restify/issues/1984
826845
restify:
827846
runs-on: ubuntu-latest
828847
env:
829848
PLUGINS: restify
830849
steps:
831850
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
832-
- uses: ./.github/actions/plugins/test
851+
- uses: ./.github/actions/testagent/start
852+
- uses: ./.github/actions/node/active-lts
853+
- uses: ./.github/actions/install
854+
- run: yarn test:plugins:ci
855+
- uses: ./.github/actions/node/oldest-maintenance-lts
856+
- run: yarn test:plugins:ci
833857

834858
rhea:
835859
runs-on: ubuntu-latest
@@ -864,7 +888,7 @@ jobs:
864888
steps:
865889
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
866890
- uses: ./.github/actions/testagent/start
867-
- uses: ./.github/actions/node/active-lts
891+
- uses: ./.github/actions/node/latest
868892
- uses: ./.github/actions/install
869893
- run: yarn test:plugins:ci
870894
- if: always()
@@ -890,7 +914,7 @@ jobs:
890914
steps:
891915
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
892916
- uses: ./.github/actions/testagent/start
893-
- uses: ./.github/actions/node/active-lts
917+
- uses: ./.github/actions/node/latest
894918
- uses: ./.github/actions/install
895919
- run: yarn test:plugins:ci
896920
- run: yarn test:plugins:upstream

‎.github/workflows/appsec.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
runs-on: macos-latest
2020
steps:
2121
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
22-
- uses: ./.github/actions/node/active-lts
22+
- uses: ./.github/actions/node/latest
2323
- uses: ./.github/actions/install
2424
- run: yarn test:appsec:ci
2525
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
@@ -43,7 +43,7 @@ jobs:
4343
runs-on: windows-latest
4444
steps:
4545
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
46-
- uses: ./.github/actions/node/active-lts
46+
- uses: ./.github/actions/node/latest
4747
- uses: ./.github/actions/install
4848
with:
4949
cache: 'true'
@@ -70,7 +70,7 @@ jobs:
7070
- uses: ./.github/actions/node/oldest-maintenance-lts
7171
- uses: ./.github/actions/install
7272
- run: yarn test:appsec:plugins:ci
73-
- uses: ./.github/actions/node/active-lts
73+
- uses: ./.github/actions/node/latest
7474
- run: yarn test:appsec:plugins:ci
7575
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
7676

@@ -127,7 +127,7 @@ jobs:
127127
- uses: ./.github/actions/node/oldest-maintenance-lts
128128
- uses: ./.github/actions/install
129129
- run: yarn test:appsec:plugins:ci
130-
- uses: ./.github/actions/node/active-lts
130+
- uses: ./.github/actions/node/active-lts # TODO: change this to latest once we figure out the `fresh` bug
131131
- run: yarn test:appsec:plugins:ci
132132
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
133133

@@ -140,7 +140,7 @@ jobs:
140140
- uses: ./.github/actions/node/oldest-maintenance-lts
141141
- uses: ./.github/actions/install
142142
- run: yarn test:appsec:plugins:ci
143-
- uses: ./.github/actions/node/active-lts
143+
- uses: ./.github/actions/node/latest
144144
- run: yarn test:appsec:plugins:ci
145145
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
146146

@@ -153,7 +153,7 @@ jobs:
153153
- uses: ./.github/actions/node/oldest-maintenance-lts
154154
- uses: ./.github/actions/install
155155
- run: yarn test:appsec:plugins:ci
156-
- uses: ./.github/actions/node/active-lts
156+
- uses: ./.github/actions/node/latest
157157
- run: yarn test:appsec:plugins:ci
158158
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
159159

@@ -172,7 +172,7 @@ jobs:
172172
- uses: ./.github/actions/node/oldest-maintenance-lts
173173
- uses: ./.github/actions/install
174174
- run: yarn test:appsec:plugins:ci
175-
- uses: ./.github/actions/node/active-lts
175+
- uses: ./.github/actions/node/latest
176176
- run: yarn test:appsec:plugins:ci
177177
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
178178

@@ -191,7 +191,7 @@ jobs:
191191
- uses: ./.github/actions/node/oldest-maintenance-lts
192192
- uses: ./.github/actions/install
193193
- run: yarn test:appsec:plugins:ci
194-
- uses: ./.github/actions/node/active-lts
194+
- uses: ./.github/actions/node/latest
195195
- run: yarn test:appsec:plugins:ci
196196
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
197197

@@ -264,7 +264,7 @@ jobs:
264264
- uses: ./.github/actions/node/oldest-maintenance-lts
265265
- uses: ./.github/actions/install
266266
- run: yarn test:appsec:plugins:ci
267-
- uses: ./.github/actions/node/active-lts
267+
- uses: ./.github/actions/node/latest
268268
- run: yarn test:appsec:plugins:ci
269269
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
270270

@@ -290,7 +290,7 @@ jobs:
290290
- uses: ./.github/actions/node/oldest-maintenance-lts
291291
- uses: ./.github/actions/install
292292
- run: yarn test:appsec:plugins:ci
293-
- uses: ./.github/actions/node/active-lts
293+
- uses: ./.github/actions/node/latest
294294
- run: yarn test:appsec:plugins:ci
295295
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
296296

@@ -303,7 +303,7 @@ jobs:
303303
- uses: ./.github/actions/node/oldest-maintenance-lts
304304
- uses: ./.github/actions/install
305305
- run: yarn test:appsec:plugins:ci
306-
- uses: ./.github/actions/node/active-lts
306+
- uses: ./.github/actions/node/latest
307307
- run: yarn test:appsec:plugins:ci
308308
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
309309

@@ -316,7 +316,7 @@ jobs:
316316
- uses: ./.github/actions/node/oldest-maintenance-lts
317317
- uses: ./.github/actions/install
318318
- run: yarn test:appsec:plugins:ci
319-
- uses: ./.github/actions/node/active-lts
319+
- uses: ./.github/actions/node/latest
320320
- run: yarn test:appsec:plugins:ci
321321
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
322322

@@ -348,6 +348,6 @@ jobs:
348348
- uses: ./.github/actions/node/oldest-maintenance-lts
349349
- uses: ./.github/actions/install
350350
- run: yarn test:appsec:plugins:ci
351-
- uses: ./.github/actions/node/active-lts
351+
- uses: ./.github/actions/node/latest
352352
- run: yarn test:appsec:plugins:ci
353353
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3

‎.github/workflows/audit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
17-
- uses: ./.github/actions/node/active-lts
17+
- uses: ./.github/actions/node/latest
1818
- run: yarn audit

‎.github/workflows/eslint-rules.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ jobs:
1818
runs-on: ubuntu-latest
1919
steps:
2020
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
21-
- uses: ./.github/actions/node/active-lts
21+
- uses: ./.github/actions/node/latest
2222
- uses: ./.github/actions/install
2323
- run: yarn test:eslint-rules

‎.github/workflows/llmobs.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
- run: yarn test:plugins:ci
4747
- run: yarn test:llmobs:plugins:ci
4848
shell: bash
49-
- uses: ./.github/actions/node/active-lts
49+
- uses: ./.github/actions/node/latest
5050
- run: yarn test:plugins:ci
5151
- run: yarn test:llmobs:plugins:ci
5252
shell: bash
@@ -68,7 +68,7 @@ jobs:
6868
- run: yarn test:plugins:ci
6969
- run: yarn test:llmobs:plugins:ci
7070
shell: bash
71-
- uses: ./.github/actions/node/active-lts
71+
- uses: ./.github/actions/node/latest
7272
- run: yarn test:plugins:ci
7373
- run: yarn test:llmobs:plugins:ci
7474
shell: bash
@@ -89,7 +89,7 @@ jobs:
8989
- uses: ./.github/actions/install
9090
- run: yarn test:llmobs:plugins:ci
9191
shell: bash
92-
- uses: ./.github/actions/node/active-lts
92+
- uses: ./.github/actions/node/latest
9393
- run: yarn test:llmobs:plugins:ci
9494
shell: bash
9595
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
@@ -110,7 +110,7 @@ jobs:
110110
- run: yarn test:plugins:ci
111111
- run: yarn test:llmobs:plugins:ci
112112
shell: bash
113-
- uses: ./.github/actions/node/active-lts
113+
- uses: ./.github/actions/node/latest
114114
- run: yarn test:plugins:ci
115115
- run: yarn test:llmobs:plugins:ci
116116
shell: bash

0 commit comments

Comments
 (0)