Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix actual grpc status code being overridden by auto-cancellation #2339

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Sep 1, 2022

What does this PR do?

Fix actual grpc status code being overridden by auto-cancellation.

Motivation

Fixes #2170

@rochdev rochdev added bug Something isn't working integrations semver-patch labels Sep 1, 2022
@rochdev rochdev requested a review from a team as a code owner September 1, 2022 19:51
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Overall package size

Self size: 2.73 MB
Deduped: 30.37 MB
No deduping: 31.02 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.0.2 8.74 MB 14.46 MB
@datadog/native-metrics 1.4.2 6.61 MB 7.04 MB
@datadog/native-appsec 1.2.1 5.1 MB 5.43 MB
cidr-matcher 2.1.1 224.94 kB 451.39 kB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
semver 5.7.1 61.58 kB 61.58 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.1 30.44 kB 34.91 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #2339 (4f0faf9) into master (f2325de) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2339   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         239      239           
  Lines        9241     9245    +4     
=======================================
+ Hits         8596     8600    +4     
  Misses        645      645           
Impacted Files Coverage Δ
...ckages/datadog-instrumentations/src/grpc/server.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integrations semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc server plugin reports wrong status code
2 participants