-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for global fetch #3258
Conversation
Overall package sizeSelf size: 4.39 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3258 +/- ##
==========================================
+ Coverage 85.97% 86.10% +0.12%
==========================================
Files 194 194
Lines 7510 7518 +8
Branches 33 33
==========================================
+ Hits 6457 6473 +16
+ Misses 1053 1045 -8
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksComparing candidate commit e547537 in PR branch Found 2 performance improvements and 21 performance regressions! Performance is the same for 420 metrics, 29 unstable metrics. scenario:log-without-log-18
scenario:log-with-debug-18
scenario:log-skip-log-18
scenario:log-with-error-18
scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-on-max-18
scenario:plugin-bluebird-with-tracer-18
scenario:net-with-tracer-18
scenario:startup-with-tracer-18
scenario:spans-finish-immediately-18
|
What does this PR do?
Add support for global
fetch
.Motivation
The
fetch
global was enabled by default in Node 18 and has been increasing in popularity.Plugin Checklist
Additional Notes
I tried adding support for
node-fetch
, but it uses ESM which makes it a lot more annoying to instrument so I kept this just for globalfetch
for now.