Git executable not found error #9981
Assignees
Comments
|
Thanks for raising this issue, @ollz272. We'll see how we can help. |
2 tasks
romainkomorndatadog
added a commit
that referenced
this issue
Aug 1, 2024
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this issue
Aug 1, 2024
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit c460441)
2 tasks
romainkomorndatadog
added a commit
that referenced
this issue
Aug 1, 2024
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit c460441)
2 tasks
romainkomorndatadog
added a commit
that referenced
this issue
Aug 1, 2024
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit c460441)
2 tasks
romainkomorndatadog
added a commit
that referenced
this issue
Aug 1, 2024
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit c460441)
2 tasks
romainkomorndatadog
added a commit
that referenced
this issue
Aug 2, 2024
…#10025) Backport c460441 from #9989 to 2.9. Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
romainkomorndatadog
added a commit
that referenced
this issue
Aug 2, 2024
#10022) Backport c460441 from #9989 to 2.10. Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
romainkomorndatadog
added a commit
that referenced
this issue
Aug 2, 2024
…#10024) Backport c460441 from #9989 to 2.8. Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of problem
When trying to upgrade from 2.9.3 and beyond, we get an error that a git exectuable can't be found on bitbucket pipelines:
Which version of dd-trace-py are you using?
2.9.3, 2.10.1
Which version of pip are you using?
Unsure
How can we reproduce your problem?
Try running tests in bitbucket with ddrace 2.9.3 installed.
What is the result that you get?
We get a crash because git can't be found.
What is the result that you expected?
The tests to run as normal
The text was updated successfully, but these errors were encountered: