Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): fix idna package test #10377

Merged
merged 16 commits into from
Aug 26, 2024
Merged

chore(iast): fix idna package test #10377

merged 16 commits into from
Aug 26, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Aug 26, 2024

Description

  • Fix IDNA package test.
  • Make the warning about a package that was marked as failing now working a warning (xfail).

Signed-off-by: Juanjo Alvarez juanjo.alvarezmartinez@datadoghq.com

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@juanjux juanjux added the ASM Application Security Monitoring label Aug 26, 2024
@juanjux juanjux self-assigned this Aug 26, 2024
@juanjux juanjux requested a review from a team as a code owner August 26, 2024 10:09
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/appsec/iast_packages/test_packages.py                             @DataDog/asm-python

@juanjux juanjux enabled auto-merge (squash) August 26, 2024 10:10
@juanjux juanjux added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 26, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 26, 2024

Datadog Report

Branch report: juanjux/idna-test-works
Commit report: 4e64bd3
Test service: dd-trace-py

✅ 0 Failed, 2236 Passed, 2191 Skipped, 43m 50.8s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Aug 26, 2024

Benchmarks

Benchmark execution time: 2024-08-26 13:39:24

Comparing candidate commit 4e64bd3 in PR branch juanjux/idna-test-works with baseline commit ee75b12 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@juanjux juanjux disabled auto-merge August 26, 2024 11:13
@juanjux juanjux closed this Aug 26, 2024
@juanjux juanjux reopened this Aug 26, 2024
@avara1986 avara1986 merged commit fbde764 into main Aug 26, 2024
166 checks passed
@avara1986 avara1986 deleted the juanjux/idna-test-works branch August 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants