Add support for gevent.pool.Pool and gevent.pool.Group #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
approved these changes
Oct 11, 2018
| @@ -17,15 +34,23 @@ class TracedGreenlet(gevent.Greenlet): | |||
| ``Greenlet`` class means extending automatically ``TracedGreenlet``. | |||
| """ | |||
| def __init__(self, *args, **kwargs): | |||
There was a problem hiding this comment.
This whole __init__ method should be able to go away if all we are doing is calling super().__init__()
class TracedGreenlet(TracingMixin, gevent.Greenlet):
pass
class TracedIMapUnordered(TracingMixing, gpool.IMapUnorderd):
passThere was a problem hiding this comment.
also, not a big deal if we keep these as-is (with __init__), not a required change to make to land this.
Kyle-Verhoog
approved these changes
Oct 11, 2018
| for s in inner_spans: | ||
| eq_('greenlet', s.name) | ||
| eq_('base', s.resource) | ||
| eq_(outer_span.trace_id, s.trace_id) |
There was a problem hiding this comment.
Out of interest since gevent 1.3 was released earlier this year I tried adding it to our test suite.
This test appears to fail for gevent>=1.3. However we don't officially support gevent>=1.3 so this is okay for now. Just something to keep in mind when we come around to supporting 1.3. 😄
labbati
approved these changes
Oct 11, 2018
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #275.