-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci-visibility): capture timeout errors #6352
Merged
emmettbutler
merged 13 commits into
1.x
from
gnufede/ci-visibility-capture-timeout-exceptions
Jul 16, 2023
Merged
chore(ci-visibility): capture timeout errors #6352
emmettbutler
merged 13 commits into
1.x
from
gnufede/ci-visibility-capture-timeout-exceptions
Jul 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnufede
added
changelog/no-changelog
A changelog entry is not required for this PR.
CI App
labels
Jul 13, 2023
BenchmarksComparing candidate commit 34014d4 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 93 cases. scenario:flasksimple-appsec-get
|
emmettbutler
previously approved these changes
Jul 14, 2023
gnufede
force-pushed
the
gnufede/ci-visibility-capture-timeout-exceptions
branch
from
July 14, 2023 15:11
e8ea570
to
c812df0
Compare
romainkomorndatadog
previously approved these changes
Jul 14, 2023
romainkomorndatadog
approved these changes
Jul 14, 2023
emmettbutler
approved these changes
Jul 14, 2023
emmettbutler
deleted the
gnufede/ci-visibility-capture-timeout-exceptions
branch
July 16, 2023 08:56
romainkomorndatadog
pushed a commit
that referenced
this pull request
Aug 8, 2023
CI Visibility: Capture timeout errors in requests to the backend ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Visibility: Capture timeout errors in requests to the backend
Checklist
changelog/no-changelog
.Reviewer Checklist