Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci-visibility): capture timeout errors #6352

Merged
merged 13 commits into from
Jul 16, 2023

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jul 13, 2023

CI Visibility: Capture timeout errors in requests to the backend

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Jul 13, 2023
@pr-commenter
Copy link

pr-commenter bot commented Jul 13, 2023

Benchmarks

Comparing candidate commit 34014d4 in PR branch gnufede/ci-visibility-capture-timeout-exceptions with baseline commit a0803f9 in branch 1.x.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 93 cases.

scenario:flasksimple-appsec-get

  • 🟩 execution_time [-0.352ms; -0.317ms] or [-5.568%; -5.012%]

@gnufede gnufede marked this pull request as ready for review July 13, 2023 16:36
@gnufede gnufede requested review from a team as code owners July 13, 2023 16:36
emmettbutler
emmettbutler previously approved these changes Jul 14, 2023
ddtrace/internal/ci_visibility/recorder.py Outdated Show resolved Hide resolved
@emmettbutler emmettbutler enabled auto-merge (squash) July 14, 2023 13:33
@gnufede gnufede requested a review from a team as a code owner July 14, 2023 14:54
@gnufede gnufede force-pushed the gnufede/ci-visibility-capture-timeout-exceptions branch from e8ea570 to c812df0 Compare July 14, 2023 15:11
tests/ci_visibility/test_ci_visibility.py Outdated Show resolved Hide resolved
@emmettbutler emmettbutler merged commit f7ffe6d into 1.x Jul 16, 2023
@emmettbutler emmettbutler deleted the gnufede/ci-visibility-capture-timeout-exceptions branch July 16, 2023 08:56
@github-actions github-actions bot added this to the v1.17.0 milestone Jul 16, 2023
romainkomorndatadog pushed a commit that referenced this pull request Aug 8, 2023
CI Visibility: Capture timeout errors in requests to the backend

## Checklist
- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants