Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add crashtracker, update libdatadog to v10.0 #8744

Closed
wants to merge 84 commits into from

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Mar 22, 2024

PROF-10246

This PR does two things

First, it updates the libdatadog dependency to v10.0. This enhances the RSS overhead of profiling collection, among many other fixups.

Second, it exposes an interface to the crashtracker, which is a component shipped out of the libdatadog profiling FFI. The precise build process for crashtracker here is somewhat convoluted because:

  • We want to make the final distribution size as small as possible
  • In service of that point, libdatadog and the associated shim wrappers are consolidated into a single libdd_wrapper.so
  • On Linux, that .so is configured in the RPATH of many other .so
  • Moreover, crashtracker requires a receiver binary, which again must rely on libdd_wrapper.so
  • The interface to crashtracker is cythonized (for now), forcing us to transpile, then compile and link manually instead of through the normal cythonize() helpers (i.e., we build in cmake instead of the usual cythonize in setup.py)

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: sanchda/libdatadog7
Commit report: 9a4a38c
Test service: dd-trace-py

✅ 0 Failed, 144662 Passed, 27774 Skipped, 9h 24m 2.34s Total duration (2h 37m 57.91s time saved)

@sanchda sanchda changed the title chore(profiling): update libdatadog to 7.0 chore(profiling): update libdatadog to 7.0 and add crashtracker Mar 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Mar 22, 2024

Benchmarks

Benchmark execution time: 2024-06-27 19:39:30

Comparing candidate commit 8ba05cb in PR branch sanchda/libdatadog7 with baseline commit 1df1d90 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@sanchda sanchda changed the title chore(profiling): update libdatadog to 7.0 and add crashtracker chore(profiling): update libdatadog to 8.0 and add crashtracker Apr 11, 2024
@github-actions github-actions bot added the stale label Jun 19, 2024
@sanchda sanchda removed the stale label Jun 27, 2024
@sanchda sanchda changed the title feat(core): add crashtracker, update libdatadog to v9.0 feat(core): add crashtracker, update libdatadog to v10.0 Jun 27, 2024
@sanchda sanchda closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants