-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add crashtracker, update libdatadog to v10.0 #8744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 144662 Passed, 27774 Skipped, 9h 24m 2.34s Total duration (2h 37m 57.91s time saved) |
sanchda
changed the title
chore(profiling): update libdatadog to 7.0
chore(profiling): update libdatadog to 7.0 and add crashtracker
Mar 22, 2024
…into sanchda/libdatadog7
sanchda
changed the title
chore(profiling): update libdatadog to 7.0 and add crashtracker
chore(profiling): update libdatadog to 8.0 and add crashtracker
Apr 11, 2024
ddtrace/internal/datadog/profiling/dd_wrapper/utils/crashtracker_test_server.py
Fixed
Show resolved
Hide resolved
taegyunkim
reviewed
Jun 24, 2024
…into sanchda/libdatadog7
taegyunkim
requested changes
Jun 26, 2024
ddtrace/internal/datadog/profiling/crashtracker/_crashtracker.pyi
Outdated
Show resolved
Hide resolved
ddtrace/internal/datadog/profiling/crashtracker/_crashtracker.pyx
Outdated
Show resolved
Hide resolved
sanchda
changed the title
feat(core): add crashtracker, update libdatadog to v9.0
feat(core): add crashtracker, update libdatadog to v10.0
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROF-10246
This PR does two things
First, it updates the libdatadog dependency to v10.0. This enhances the RSS overhead of profiling collection, among many other fixups.
Second, it exposes an interface to the crashtracker, which is a component shipped out of the libdatadog profiling FFI. The precise build process for crashtracker here is somewhat convoluted because:
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist