-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(telemetry): expect observed test result #8773
Conversation
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 170730 Passed, 1909 Skipped, 11h 47m 40.84s Total duration (42m 40.94s time saved) ❌ Failed Tests (1)
|
BenchmarksBenchmark execution time: 2024-03-26 17:20:03 Comparing candidate commit 67141dd in PR branch Found 1 performance improvements and 4 performance regressions! Performance is the same for 196 metrics, 9 unstable metrics. scenario:flasksimple-appsec-telemetry
scenario:httppropagationextract-invalid_span_id_header
scenario:httppropagationextract-large_valid_headers_all
scenario:httppropagationextract-medium_valid_headers_all
scenario:httppropagationextract-wsgi_valid_headers_all
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current changes look good but we can simplify this test to avoid the flaky behavior. We can also use this strategy to improve the reliability of other telemetry tests.
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
This change makes an unreliable test expect the results that it actually gets in CI:
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/58336/workflows/1bed424b-752e-4748-b3ef-ce3cad32ea72/jobs/3688991
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist