-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(llmobs): correctly cast bedrock token/temperature parameters #8790
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 288 Passed, 647 Skipped, 7m 1.87s Total duration (32m 56.59s time saved) |
BenchmarksBenchmark execution time: 2024-03-27 16:38:09 Comparing candidate commit 6a2dbbd in PR branch Found 5 performance improvements and 2 performance regressions! Performance is the same for 194 metrics, 9 unstable metrics. scenario:httppropagationextract-large_header_no_matches
scenario:httppropagationextract-medium_header_no_matches
scenario:httppropagationextract-none_propagation_style
scenario:httppropagationextract-wsgi_invalid_trace_id_header
scenario:httppropagationextract-wsgi_large_header_no_matches
scenario:httppropagationextract-wsgi_medium_header_no_matches
scenario:sethttpmeta-all-enabled
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see in line 234
n = int(span.get_tag("bedrock.request.n"))
Might want to change to
n = int(span.get_tag("bedrock.request.n") or 0)
This PR fixes the AWS bedrock integration to default tag an empty string if an input parameter is not provided (preivously we defaulted to `"None"`), as that led to casting errors on the LLMObs integration side when we try to cast the span tag value to an int/float. Now, we default tag to an empty string, which avoids the casting errors we had previously, and only add the `max_tokens` parameter to the LLMObs span event if it is a non-null value. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [X] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [X] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
This PR fixes the AWS bedrock integration to default tag an empty string if an input parameter is not provided (preivously we defaulted to
"None"
), as that led to casting errors on the LLMObs integration side when we try to cast the span tag value to an int/float.Now, we default tag to an empty string, which avoids the casting errors we had previously, and only add the
max_tokens
parameter to the LLMObs span event if it is a non-null value.Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist