Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip forkserver multiprocessing profiling test because it is unreliable #8806

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Mar 28, 2024

This change fixes CI failures like this one by skipping the test.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/flaky-forkserver
Commit report: ec1803b
Test service: dd-trace-py

✅ 0 Failed, 151885 Passed, 20898 Skipped, 10h 30m 20.01s Total duration (1h 40m 13.21s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Mar 28, 2024

Benchmarks

Benchmark execution time: 2024-03-28 21:00:57

Comparing candidate commit ec1803b in PR branch emmett.butler/flaky-forkserver with baseline commit 8ab2d72 in branch main.

Found 5 performance improvements and 2 performance regressions! Performance is the same for 194 metrics, 9 unstable metrics.

scenario:flasksimple-debugger

  • 🟥 execution_time [+323.483µs; +376.327µs] or [+5.146%; +5.987%]

scenario:httppropagationextract-large_header_no_matches

  • 🟩 max_rss_usage [-763.141KB; -693.806KB] or [-3.488%; -3.171%]

scenario:httppropagationextract-medium_header_no_matches

  • 🟩 max_rss_usage [-757.848KB; -681.487KB] or [-3.468%; -3.119%]

scenario:httppropagationextract-none_propagation_style

  • 🟩 max_rss_usage [-1026.372KB; -705.007KB] or [-4.688%; -3.220%]

scenario:httppropagationextract-wsgi_invalid_trace_id_header

  • 🟥 max_rss_usage [+528.252KB; +720.209KB] or [+2.502%; +3.411%]

scenario:httppropagationextract-wsgi_large_header_no_matches

  • 🟩 max_rss_usage [-750.678KB; -667.357KB] or [-3.432%; -3.051%]

scenario:httppropagationextract-wsgi_medium_header_no_matches

  • 🟩 max_rss_usage [-774.196KB; -702.002KB] or [-3.537%; -3.208%]

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 29, 2024
@emmettbutler emmettbutler enabled auto-merge (squash) March 29, 2024 13:19
@emmettbutler emmettbutler merged commit d041207 into main Mar 29, 2024
157 of 158 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/flaky-forkserver branch March 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants