Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: depend on ddsketch 3 #8810

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Mar 29, 2024

This change upgrades the ddsketch dependency to one that doesn't depend on protobuf. This aids the bugfix in #8797 by completely removing protobuf from the entire dependency tree.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added changelog/no-changelog A changelog entry is not required for this PR. backport 2.7 labels Mar 29, 2024
@emmettbutler emmettbutler requested review from a team as code owners March 29, 2024 18:19
@emmettbutler emmettbutler marked this pull request as draft March 29, 2024 18:19
@emmettbutler
Copy link
Collaborator Author

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 1, 2024

Datadog Report

Branch report: emmett.butler/ddsketch-upgrade
Commit report: 97890b3
Test service: dd-trace-py

✅ 0 Failed, 585 Passed, 1 Skipped, 16m 31.43s Total duration (1m 37.78s time saved)

@emmettbutler emmettbutler marked this pull request as ready for review April 1, 2024 13:42
@pr-commenter
Copy link

pr-commenter bot commented Apr 1, 2024

Benchmarks

Benchmark execution time: 2024-04-01 14:23:28

Comparing candidate commit ed6e9e0 in PR branch emmett.butler/ddsketch-upgrade with baseline commit 907b7e8 in branch main.

Found 4 performance improvements and 1 performance regressions! Performance is the same for 196 metrics, 9 unstable metrics.

scenario:httppropagationextract-large_header_no_matches

  • 🟩 max_rss_usage [-783.312KB; -711.728KB] or [-3.577%; -3.250%]

scenario:httppropagationextract-medium_header_no_matches

  • 🟩 max_rss_usage [-790.755KB; -721.488KB] or [-3.615%; -3.298%]

scenario:httppropagationextract-wsgi_invalid_priority_header

  • 🟥 max_rss_usage [+504.522KB; +733.699KB] or [+2.387%; +3.471%]

scenario:httppropagationextract-wsgi_large_header_no_matches

  • 🟩 max_rss_usage [-773.907KB; -699.015KB] or [-3.538%; -3.196%]

scenario:httppropagationextract-wsgi_medium_header_no_matches

  • 🟩 max_rss_usage [-786.079KB; -707.733KB] or [-3.595%; -3.237%]

@emmettbutler emmettbutler enabled auto-merge (squash) April 1, 2024 17:38
@emmettbutler emmettbutler merged commit 6c68609 into main Apr 1, 2024
176 of 177 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/ddsketch-upgrade branch April 1, 2024 18:00
github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
This change upgrades the ddsketch dependency to one that doesn't depend
on protobuf. This aids the bugfix in
#8797 by completely removing
protobuf from the entire dependency tree.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 6c68609)
gnufede pushed a commit that referenced this pull request Apr 3, 2024
Backport 6c68609 from #8810 to 2.7.

This change upgrades the ddsketch dependency to one that doesn't depend
on protobuf. This aids the bugfix in
#8797 by completely removing
protobuf from the entire dependency tree.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants