Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(telemetry): only allow get_events to return each event one time #8820

Merged
merged 8 commits into from
Apr 1, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 1, 2024

An attempt at a more durable fix for test failures like this one by deduplicating the events returned from test_agent_session.get_events().

Removed assertions are because they don't apply given this fix.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner April 1, 2024 14:52
@emmettbutler emmettbutler marked this pull request as draft April 1, 2024 14:52
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 1, 2024

Datadog Report

Branch report: emmett.butler/gotten-events
Commit report: 07c7a10
Test service: dd-trace-py

✅ 0 Failed, 77 Passed, 349 Skipped, 45.22s Total duration (41.43s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Apr 1, 2024

Benchmarks

Benchmark execution time: 2024-04-01 18:22:58

Comparing candidate commit 07c7a10 in PR branch emmett.butler/gotten-events with baseline commit ad2fe25 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 200 metrics, 9 unstable metrics.

scenario:flasksimple-appsec-telemetry

  • 🟥 execution_time [+220.176µs; +267.459µs] or [+3.517%; +4.272%]

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 1, 2024
@emmettbutler emmettbutler changed the title ci: only allow get_events to return each event one time ci(telemetry): only allow get_events to return each event one time Apr 1, 2024
@emmettbutler emmettbutler marked this pull request as ready for review April 1, 2024 17:36
tests/conftest.py Outdated Show resolved Hide resolved
@emmettbutler emmettbutler enabled auto-merge (squash) April 1, 2024 19:10
@emmettbutler emmettbutler merged commit b374a5a into main Apr 1, 2024
156 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/gotten-events branch April 1, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants