ci: add ITR unskippable marker if subprocess marker is used #9261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainkomorndatadog
added
changelog/no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 174286 Passed, 1593 Skipped, 11h 3m 0.11s Total duration (23m 50.68s time saved) |
romainkomorndatadog
changed the title
…ble_if_using_subprocess_marker
gnufede
approved these changes
May 14, 2024
BenchmarksBenchmark execution time: 2024-05-16 16:38:59 Comparing candidate commit 4f6d960 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics. |
…ble_if_using_subprocess_marker
…ble_if_using_subprocess_marker
emmettbutler
approved these changes
May 15, 2024
…ble_if_using_subprocess_marker
emmettbutler
changed the title
…ble_if_using_subprocess_marker
brettlangdon
approved these changes
May 15, 2024
…ble_if_using_subprocess_marker
…ble_if_using_subprocess_marker
…ble_if_using_subprocess_marker
…g_subprocess_marker' of github.com:DataDog/dd-trace-py into romain.komorn/CIVIS-10031/make_test_unskippable_if_using_subprocess_marker
…ble_if_using_subprocess_marker
romainkomorndatadog
deleted the
romain.komorn/CIVIS-10031/make_test_unskippable_if_using_subprocess_marker
branch
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used. Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what. This ends up with tests being forced to run and the `test.itr.unskippable` tag being set to `true`:  ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 370b175)
17 tasks
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used. Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what. This ends up with tests being forced to run and the `test.itr.unskippable` tag being set to `true`:  ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 370b175)
17 tasks
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used. Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what. This ends up with tests being forced to run and the `test.itr.unskippable` tag being set to `true`:  ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 370b175)
17 tasks
romainkomorndatadog
added a commit
that referenced
this pull request
May 20, 2024
… 2.9] (#9303) Backport 370b175 from #9261 to 2.9. This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used. Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what. This ends up with tests being forced to run and the `test.itr.unskippable` tag being set to `true`:  ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
brettlangdon
pushed a commit
that referenced
this pull request
May 20, 2024
… 2.8] (#9302) Backport 370b175 from #9261 to 2.8. This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used. Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what. This ends up with tests being forced to run and the `test.itr.unskippable` tag being set to `true`:  ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
brettlangdon
pushed a commit
that referenced
this pull request
May 28, 2024
… 2.7] (#9301) Backport 370b175 from #9261 to 2.7. This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used. Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what. This ends up with tests being forced to run and the `test.itr.unskippable` tag being set to `true`:  ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue where tests are improperly being skipped due to issues collecting coverage data using coverage.py when subprocess is used.
Whenever the subprocess marker is seen during collection, we add the same skipif marker that's used to mark tests as unskippable, which makes pytest run the tests no matter what.
This ends up with tests being forced to run and the
test.itr.unskippabletag being set totrue:Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist