Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): smoke tests importing the top 100 popular modules #9348

Merged
merged 9 commits into from
May 23, 2024

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented May 22, 2024

Smoke tests importing the top 100 popular modules.

I skipped some modules, the reasons are:

  • no documentation
  • no related to web services (installation packages like setup tools, colorama is a terminal script...)
  • import error (importlib.import_module(boto3) raises an error)

Here is the script that I used to extract the top popular modules from https://pypistats.org/top and https://hugovk.github.io/top-pypi-packages/

https://gist.github.com/avara1986/87658015fd29cb7b38fd79210a04a091

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels May 22, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 22, 2024

Datadog Report

Branch report: avara1986/APPSEC-53117-enable_smoke_test
Commit report: 45b47ac
Test service: dd-trace-py

✅ 0 Failed, 110456 Passed, 2609 Skipped, 5m 19.39s Total duration (19m 0.74s time saved)

@pr-commenter
Copy link

pr-commenter bot commented May 22, 2024

Benchmarks

Benchmark execution time: 2024-05-23 09:10:48

Comparing candidate commit 45b47ac in PR branch avara1986/APPSEC-53117-enable_smoke_test with baseline commit f251e5b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 10.25%. Comparing base (66b96e9) to head (45b47ac).
Report is 9 commits behind head on main.

Files Patch % Lines
tests/appsec/iast_packages/test_packages.py 0.00% 39 Missing ⚠️
tests/appsec/iast/aspects/conftest.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9348       +/-   ##
===========================================
- Coverage   76.02%   10.25%   -65.77%     
===========================================
  Files        1294     1266       -28     
  Lines      122816   121238     -1578     
===========================================
- Hits        93370    12437    -80933     
- Misses      29446   108801    +79355     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avara1986 avara1986 marked this pull request as ready for review May 23, 2024 08:32
@avara1986 avara1986 requested a review from a team as a code owner May 23, 2024 08:32
@avara1986 avara1986 merged commit 3de0cf5 into main May 23, 2024
64 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-53117-enable_smoke_test branch May 23, 2024 10:25
@avara1986 avara1986 mentioned this pull request May 23, 2024
18 tasks
avara1986 added a commit that referenced this pull request May 24, 2024
Enable more packages and filter by python version or add docstring to
explain why is not working

This PR continues #9348
## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants