-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iast): smoke tests importing the top 100 popular modules #9348
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 110456 Passed, 2609 Skipped, 5m 19.39s Total duration (19m 0.74s time saved) |
BenchmarksBenchmark execution time: 2024-05-23 09:10:48 Comparing candidate commit 45b47ac in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9348 +/- ##
===========================================
- Coverage 76.02% 10.25% -65.77%
===========================================
Files 1294 1266 -28
Lines 122816 121238 -1578
===========================================
- Hits 93370 12437 -80933
- Misses 29446 108801 +79355 ☔ View full report in Codecov by Sentry. |
Enable more packages and filter by python version or add docstring to explain why is not working This PR continues #9348 ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Smoke tests importing the top 100 popular modules.
I skipped some modules, the reasons are:
importlib.import_module(boto3)
raises an error)Here is the script that I used to extract the top popular modules from
https://pypistats.org/top
andhttps://hugovk.github.io/top-pypi-packages/
https://gist.github.com/avara1986/87658015fd29cb7b38fd79210a04a091
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist