Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): gate coverage-related checks to ITR-supported versions #9363

Merged

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented May 23, 2024

Internal coverage use for pytest only applies to ITR, so we introduce a function to check whether the pytest version supports ITR, and configure the plugin and hooks accordingly.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label May 23, 2024
@romainkomorndatadog romainkomorndatadog self-assigned this May 23, 2024
@romainkomorndatadog romainkomorndatadog requested a review from a team as a code owner May 23, 2024 09:45
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: romain.komorn/CIVIS-9428/support_pytest_lt_5.1
Commit report: 4ddb047
Test service: dd-trace-py

✅ 0 Failed, 174698 Passed, 1149 Skipped, 11h 22m 41.76s Total duration (26m 37.21s time saved)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 10.26%. Comparing base (66b96e9) to head (4ddb047).
Report is 9 commits behind head on main.

Files Patch % Lines
ddtrace/contrib/pytest/_plugin_v1.py 0.00% 12 Missing ⚠️
ddtrace/contrib/pytest/utils.py 30.00% 7 Missing ⚠️
ddtrace/contrib/pytest/plugin.py 33.33% 2 Missing ⚠️
ddtrace/contrib/pytest/constants.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9363       +/-   ##
===========================================
- Coverage   76.02%   10.26%   -65.77%     
===========================================
  Files        1294     1267       -27     
  Lines      122816   121232     -1584     
===========================================
- Hits        93370    12441    -80929     
- Misses      29446   108791    +79345     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romainkomorndatadog
Copy link
Collaborator Author

Side note, this is not a "fix" because the issue this PR fixes (compatibility with pytest < 5.something) was introduced in #8727 which has yet to be released.

@romainkomorndatadog romainkomorndatadog enabled auto-merge (squash) May 28, 2024 12:21
@romainkomorndatadog romainkomorndatadog merged commit 7daea82 into main May 28, 2024
70 of 71 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/CIVIS-9428/support_pytest_lt_5.1 branch May 28, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants