Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bs4 & sanic framework test #9371

Merged
merged 24 commits into from
May 24, 2024

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented May 24, 2024

Add BeautifulSoup and Sanic to the framework tests.
Add a small fix in ddtrace/internal/compat.py to avoid raising an error if we receive a mock instead of a string. There is the error: https://github.com/DataDog/dd-trace-py/actions/runs/9223552867/job/25377041389#step:7:257

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added CI changelog/no-changelog A changelog entry is not required for this PR. labels May 24, 2024
@avara1986 avara1986 changed the title chore(ci): BeautifulSoup framework test chore(ci): bs4 framework test May 24, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 24, 2024

Datadog Report

Branch report: avara1986/APPSEC-53237_bs4_framework_test
Commit report: 89d87f7
Test service: dd-trace-py

✅ 0 Failed, 118874 Passed, 58366 Skipped, 3h 53m 20.51s Total duration (6h 34m 15.65s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.25%. Comparing base (609a306) to head (e41fa1d).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9371       +/-   ##
===========================================
- Coverage   75.91%   10.25%   -65.66%     
===========================================
  Files        1296     1266       -30     
  Lines      123084   121238     -1846     
===========================================
- Hits        93442    12439    -81003     
- Misses      29642   108799    +79157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented May 24, 2024

Benchmarks

Benchmark execution time: 2024-05-24 14:16:20

Comparing candidate commit 07ea80e in PR branch avara1986/APPSEC-53237_bs4_framework_test with baseline commit fd6f054 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@avara1986 avara1986 added the ASM Application Security Monitoring label May 24, 2024
@avara1986 avara1986 marked this pull request as ready for review May 24, 2024 11:45
@avara1986 avara1986 requested a review from a team as a code owner May 24, 2024 11:45
@avara1986 avara1986 requested a review from a team as a code owner May 24, 2024 12:25
@avara1986 avara1986 changed the title chore(ci): bs4 framework test chore(ci): bs4 & sanic framework test May 24, 2024
@avara1986 avara1986 enabled auto-merge (squash) May 24, 2024 15:03
@avara1986 avara1986 merged commit 4e31278 into main May 24, 2024
170 of 175 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-53237_bs4_framework_test branch May 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants