Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): ensure we publish latest_snapshot container image #9381

Merged
merged 2 commits into from
May 24, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented May 24, 2024

We need to publish this tag on commits to main.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 24, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner May 24, 2024 16:02
@brettlangdon brettlangdon enabled auto-merge (squash) May 24, 2024 16:04
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: brettlangdon/publish.latest_snapshot
Commit report: f84e291
Test service: dd-trace-py

✅ 0 Failed, 120344 Passed, 57284 Skipped, 4h 16m 16s Total duration (6h 17m 7.94s time saved)
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • test_data_streams_kafka_offset_monitoring_offsets - test_kafka.py 1m 30.12s (+1m 25.36s, +1794%) - Details

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.26%. Comparing base (e125f22) to head (f84e291).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9381       +/-   ##
===========================================
- Coverage   75.92%   10.26%   -65.66%     
===========================================
  Files        1296     1266       -30     
  Lines      123144   121311     -1833     
===========================================
- Hits        93497    12454    -81043     
- Misses      29647   108857    +79210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettlangdon brettlangdon merged commit f38dbd4 into main May 24, 2024
63 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/publish.latest_snapshot branch May 24, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants