Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): add threading and multiprocessing coverage tests #9479

Merged
merged 67 commits into from
Jun 11, 2024

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Jun 5, 2024

Adds some tests for the internal coverage tool.

Also fixes a bug where coverage absorbed from threading or multiprocessing modules was being added to the session-level coverage even when said coverage wasn't enabled.

No release note because this is experimental and unreleased.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 5, 2024
@romainkomorndatadog romainkomorndatadog self-assigned this Jun 5, 2024
@romainkomorndatadog romainkomorndatadog requested review from a team as code owners June 5, 2024 08:09
@romainkomorndatadog romainkomorndatadog requested review from emmettbutler, tonyredondo and ZStriker19 and removed request for a team June 5, 2024 08:09
Base automatically changed from romain.komorn/CIVIS-9428/add_threading_to_internal_coverage to main June 5, 2024 08:35
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2024

Benchmarks

Benchmark execution time: 2024-06-11 10:11:32

Comparing candidate commit 638baa8 in PR branch romain.komorn/CIVIS-9428/add_coverage_tests with baseline commit 360b469 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@romainkomorndatadog romainkomorndatadog enabled auto-merge (squash) June 6, 2024 06:15
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 6, 2024

Datadog Report

Branch report: romain.komorn/CIVIS-9428/add_coverage_tests
Commit report: ecd6a58
Test service: dd-trace-py

✅ 0 Failed, 119008 Passed, 59251 Skipped, 3h 57m 54.03s Total duration (3h 32m 0.93s time saved)

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 10.27%. Comparing base (cd92beb) to head (ecd6a58).
Report is 2 commits behind head on main.

Files Patch % Lines
ddtrace/internal/coverage/code.py 12.50% 7 Missing ⚠️
ddtrace/internal/coverage/instrumentation.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9479       +/-   ##
===========================================
- Coverage   75.89%   10.27%   -65.62%     
===========================================
  Files        1315     1285       -30     
  Lines      124966   123124     -1842     
===========================================
- Hits        94837    12651    -82186     
- Misses      30129   110473    +80344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romainkomorndatadog romainkomorndatadog merged commit 6a72268 into main Jun 11, 2024
162 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/CIVIS-9428/add_coverage_tests branch June 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants