-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: put ddtrace site-packages on the end of the pythonpath [APMS-12275] #9496
Conversation
…etric name changes, adding override tag to complete event
Co-authored-by: Zachary Groves <32471391+ZStriker19@users.noreply.github.com>
…ginning to avoid corrupting the app by installing different versions of its dependencies
Datadog ReportBranch report: ❌ 16 Failed (0 Known Flaky), 631 Passed, 5340 Skipped, 3m 18.17s Total duration (11m 33.96s time saved) ❌ Failed Tests (16)
|
…2275] (#9496) This change adjusts single-step instrumentation to put ddtrace's customizations on the end of the pythonpath rather than the beginning. This makes it much less likely that instrumentation will corrupt the app by causing different versions of requirements to be used. Because the injection guardrails are now handling the task of ensuring compatibility between ddtrace and app requirements, which prepending to the pythonpath was a workaround for, this new less destructive approach is available. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. --------- Co-authored-by: ZStriker19 <zach.groves@datadoghq.com> Co-authored-by: Zachary Groves <32471391+ZStriker19@users.noreply.github.com> (cherry picked from commit 4da8ed6)
…2275] [backport 2.10] (#9532) Backport 4da8ed6 from #9496 to 2.10. This change adjusts single-step instrumentation to put ddtrace's customizations on the end of the pythonpath rather than the beginning. This makes it much less likely that instrumentation will corrupt the app by causing different versions of requirements to be used. Because the injection guardrails are now handling the task of ensuring compatibility between ddtrace and app requirements, which prepending to the pythonpath was a workaround for, this new less destructive approach is available. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
This change adjusts single-step instrumentation to put ddtrace's customizations on the end of the pythonpath rather than the beginning. This makes it much less likely that instrumentation will corrupt the app by causing different versions of requirements to be used. Because the injection guardrails are now handling the task of ensuring compatibility between ddtrace and app requirements, which prepending to the pythonpath was a workaround for, this new less destructive approach is available.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.