Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(anthropic): make team ml-obs as codeowners #9516

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Jun 11, 2024

This PR makes the team @DataDog/ml-observability as codeowners for the Anthropic integration.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim requested review from a team as code owners June 11, 2024 21:20
@Yun-Kim Yun-Kim enabled auto-merge (squash) June 11, 2024 21:20
@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 11, 2024
Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: yunkim/llmobs-anthropic-codeowner
Commit report: bd05164
Test service: dd-trace-py

✅ 0 Failed, 136764 Passed, 41525 Skipped, 8h 31m 25.88s Total duration (57m 32.14s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.25%. Comparing base (cd92beb) to head (bd05164).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9516       +/-   ##
===========================================
- Coverage   75.89%   10.25%   -65.64%     
===========================================
  Files        1315     1286       -29     
  Lines      124966   123390     -1576     
===========================================
- Hits        94837    12652    -82185     
- Misses      30129   110738    +80609     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Benchmarks

Benchmark execution time: 2024-06-11 22:10:43

Comparing candidate commit bd05164 in PR branch yunkim/llmobs-anthropic-codeowner with baseline commit d7a5bd7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@Yun-Kim Yun-Kim merged commit ec67b2c into main Jun 11, 2024
171 of 173 checks passed
@Yun-Kim Yun-Kim deleted the yunkim/llmobs-anthropic-codeowner branch June 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants