Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): unboundlocalerror in redis utils #9552

Closed
wants to merge 2 commits into from

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 14, 2024

This change resolves a programming error in redis_utils.py.

Fixes #9548

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/unbound-redis
Commit report: 1779ab8
Test service: dd-trace-py

✅ 0 Failed, 876 Passed, 12 Skipped, 7m 37.54s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jun 14, 2024

Benchmarks

Benchmark execution time: 2024-06-14 17:14:54

Comparing candidate commit 1779ab8 in PR branch emmett.butler/unbound-redis with baseline commit bd047bc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@sileht
Copy link
Contributor

sileht commented Jun 18, 2024

It's a dup of #9511

@emmettbutler emmettbutler deleted the emmett.butler/unbound-redis branch June 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnboundLocalError: cannot access local variable 'result' where it is not associated with a value
2 participants