-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve macrobenchmarks [backport 2.8] #9559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve macrobenchmarks by using the new BP_ENDPOINT env var to set the endpoint to test. See DataDog/benchmarking-platform#68 This way we can add worst case scenarios for AppSec and IAST, added in the PR as well. - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit ec61873)
gnufede
changed the title
ci: improve macrobenchmarks (#9536)
ci: improve macrobenchmarks [backport 2.8]
Jun 17, 2024
gnufede
added
changelog/no-changelog
A changelog entry is not required for this PR.
CI
labels
Jun 17, 2024
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 15556 Passed, 155583 Skipped, 5h 35m 4.3s Total duration (1h 43m 29.96s time saved) ❌ Failed Tests (1)
|
emmettbutler
approved these changes
Jun 17, 2024
Blocked on #9568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve macrobenchmarks by using the new BP_ENDPOINT env var to set the endpoint to test. See
https://github.com/DataDog/benchmarking-platform/pull/68
This way we can add worst case scenarios for AppSec and IAST, added in the PR as well.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist
policy
(cherry picked from commit ec61873)