Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve macrobenchmarks [backport 2.8] #9559

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jun 17, 2024

Improve macrobenchmarks by using the new BP_ENDPOINT env var to set the endpoint to test. See
https://github.com/DataDog/benchmarking-platform/pull/68

This way we can add worst case scenarios for AppSec and IAST, added in the PR as well.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy

(cherry picked from commit ec61873)

Improve macrobenchmarks by using the new BP_ENDPOINT env var to set the
endpoint to test. See
DataDog/benchmarking-platform#68

This way we can add worst case scenarios for AppSec and IAST, added in
the PR as well.

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit ec61873)
@gnufede gnufede requested a review from a team as a code owner June 17, 2024 08:08
@gnufede gnufede changed the title ci: improve macrobenchmarks (#9536) ci: improve macrobenchmarks [backport 2.8] Jun 17, 2024
@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jun 17, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 17, 2024

Datadog Report

Branch report: backport-9536-to-2.8
Commit report: 384d4b1
Test service: dd-trace-py

❌ 1 Failed (0 Known Flaky), 15556 Passed, 155583 Skipped, 5h 35m 4.3s Total duration (1h 43m 29.96s time saved)

❌ Failed Tests (1)

  • test_get_distributions - test_packages.py - Details

    Expand for error
     assert {'attrs', 'by...ddtrace', ...} == {'attrs', 'by...ddtrace', ...}
       Extra items in the left set:
       'importlib-metadata'
       Extra items in the right set:
       'importlib_metadata'
       Full diff:
         {
          'attrs',
          'bytecode',
          'cattrs',
     ...
    

@gnufede gnufede enabled auto-merge (squash) June 17, 2024 08:43
@pr-commenter
Copy link

pr-commenter bot commented Jun 17, 2024

Benchmarks

Benchmark execution time: 2024-06-17 09:14:23

Comparing candidate commit 384d4b1 in PR branch backport-9536-to-2.8 with baseline commit 4995685 in branch 2.8.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 201 metrics, 9 unstable metrics.

@gnufede
Copy link
Member Author

gnufede commented Jun 17, 2024

Blocked on #9568

@gnufede gnufede merged commit 1177df2 into 2.8 Jun 18, 2024
36 of 43 checks passed
@gnufede gnufede deleted the backport-9536-to-2.8 branch June 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants