Fix incorrect configuration mismatch warning when port is specified as String #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s String I noticed a Ruby app where the configuration mismatch warning was popping up: ``` W, [2021-10-15T11:44:30.952540 #1] WARN -- ddtrace: [ddtrace] Configuration mismatch: values differ between "c.tracer.port" ('8126') and DD_TRACE_AGENT_PORT environment variable ('8126'). Using '8126'. ``` The warning was being triggered because we convert the values read from environment variables (`DD_TRACE_AGENT_PORT` or `DD_TRACE_AGENT_URL`) into integers, but this app had `c.tracer.port` specified as a string. Because or that, since we collect all values, call `#uniq` on them and see if we get more than one, the warning was being triggered since the `8126` integer is not the same as the `'8126'` string.
ivoanjo
changed the title
|
You can tell it's friday evening because I opened a PR called "git logIvoanjo/fix warning when port specified as string" due to not correctly focusing my terminal 🤣 |
Turns out `Integer(...)` throws `ArgumentError` when a string doesn't make sense, but `TypeError` when what it gets isn't even a string.
marcotc
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 934 934
Lines 45122 45150 +28
=======================================
+ Hits 44301 44329 +28
Misses 821 821
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a Ruby app where the configuration mismatch warning was popping up:
The warning was being triggered because we convert the values read from environment variables (
DD_TRACE_AGENT_PORTorDD_TRACE_AGENT_URL) into integers, but this app hadc.tracer.portspecified as a string.Because or that, since we collect all values, call
#uniqon them and see if we get more than one, the warning was being triggered since the8126integer is not the same as the'8126'string.