Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenient interface for getting and setting tags using [] and []= respectively. #2076

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Add convenient interface for getting and setting tags using [] and []= respectively. #2076

merged 3 commits into from
Jun 30, 2022

Conversation

ioquatix
Copy link
Contributor

Fixes #2075

I respect that you may not want to do this, but I think this would be a pretty practical and ergonomic improvement to the span interface.

@ioquatix ioquatix requested a review from a team June 10, 2022 03:27
marcotc
marcotc approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thank you @ioquatix!

I was concerned with the distinction between metrics and tags, but we handle it transparently internally, so there's no semantic conflict here.

I'd like to know what @delner thinks of this change as well.

@marcotc marcotc added the community Was opened by a community member label Jun 20, 2022
ivoanjo
ivoanjo approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcotc marcotc merged commit 41ddb4b into DataDog:master Jun 30, 2022
@github-actions github-actions bot added this to the 1.2.0 milestone Jun 30, 2022
@ioquatix ioquatix deleted the patch-1 branch June 30, 2022 21:02
@ioquatix
Copy link
Contributor Author

Thanks everyone!

@ivoanjo
Copy link
Member

ivoanjo commented Jul 11, 2022

👋 @ioquatix this change has been released in v1.2.0.
Thank you for the contribution kind sir :)

@ivoanjo ivoanjo mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
community Was opened by a community member
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Add alias []= set_tag and possibly other convenient methods.
3 participants
@ioquatix @ivoanjo @marcotc