Update robocop version to work with ruby 3.2 #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
force-pushed
the
update-rubocop-version-for-newest-ruby-versioon
branch
from
ccd8d4a
to
813a803
Compare
GustavoCaso
force-pushed
the
update-rubocop-version-for-newest-ruby-versioon
branch
from
813a803
to
6fc349a
Compare
GustavoCaso
commented
May 22, 2023
GustavoCaso
commented
May 22, 2023
| @@ -30,7 +30,7 @@ | |||
| context "for fixture #{File.basename(filename)}" do | |||
| # Create a context for each example inside the JSON fixture file | |||
| JSON.parse(f.read).each_with_index do |(env, tags), i| | |||
| context "##{i}" do | |||
| context i.to_s do | |||
There was a problem hiding this comment.
Rubocop was complaining of RSpec/ContextMethod cop.
Since i doe snot represent a method name, I decided to drop the # sign
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2870 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 1269 1269
Lines 69969 69969
Branches 3161 3161
==========================================
- Hits 68638 68633 -5
- Misses 1331 1336 +5 ☔ View full report in Codecov by Sentry. |
…e ruby version. Only install rubocop if ruby version is 2.6.0 or higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I Updated the rubocop version for the newer version of Ruby.
I primarily work on the latest version of ruby, and my IDE was complaining the rubocop version installed did not recognise ruby
3.2I added a condition on our
Gemfileto fix that.Here is the rubocop file that specifies which ruby version is supported. The update I did was a bit on the conservative side. There is a newer version of Rubocop 1.51.0.
If we feel courageous, we can try the latest version 😄
Motivation
Additional Notes
How to test the change?