-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Rails testing is considered a development environment #3062
Conversation
045eb21
to
3997a09
Compare
3997a09
to
f89f2f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to go forward with that because there are still issues with telemetry and RC being reported.
Do you think we would need to add a check for Cucumber in test?
method?
That's a good idea, I'll open a separate PR. |
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 1283 1283
Lines 73898 73918 +20
Branches 3421 3421
=======================================
+ Hits 72542 72565 +23
+ Misses 1356 1353 -3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What does this PR do?
This PR detects if a Rails application is running in
development
ortest
mode, and uses this information to informddtrace
internally in order improve logging and background worker management.Motivation
Currently, we consider local development Rails console as a production environment, which is incorrect.
Additional Notes
This checking ensures
staging
, which is a common non-stardard Rails environment is considered "not development" byddtrace
.How to test the change?
There are unit test covering this change.