-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instrumentation of custom cache stores #3206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekump
previously requested changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added two new test cases for a cache class in a different namespace and a cache class without a namespace. 👍 |
marcotc
approved these changes
Oct 23, 2023
ekump
pushed a commit
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Marco Costa <marco.costa@datadoghq.com> Co-authored-by: marcotc <marcotc@users.noreply.github.com>
2 tasks
ekump
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes #3199, by avoiding the assumption that
config.cache_store
will be set to something that exists in theActiveSupport::Cache::
namespace. By using the genericdemodularize
, it retains backwards compatibility while also supporting constants such asMyApp::CustomCache
orCustomRedisCache
.Motivation:
Much like #3199, I was seeing:
How to test the change?
Install a cache store that does not exist in the ActiveSupport namespace, such as Rails' new
solid_cache
. Upon use, the above stack trace will be reproduced.For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!