Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration for priority_sampling #3325

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 12, 2023

2.0 Upgrade Guide notes

The configuration setting c.tracing.priority_sampling has been removed. This option was used to disable priority sampling, which was enabled by default.
To disable priority sampling, you now have to create a custom sampler.

Motivation:

Priority sampling is the preferable way to store a sampling decision at Datadog.
Disabling it also disables features in the Datadog Agent and creates subpart reporting in the Ingestion Control page.

How to test the change?
There are unit and integration tests for all changes.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested review from a team as code owners December 12, 2023 22:24
@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Dec 12, 2023
@marcotc marcotc self-assigned this Dec 12, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7ef57c) 98.06% compared to head (2d1e3c0) 98.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3325      +/-   ##
==========================================
- Coverage   98.06%   98.05%   -0.01%     
==========================================
  Files        1243     1243              
  Lines       71873    71808      -65     
  Branches     3388     3381       -7     
==========================================
- Hits        70481    70414      -67     
- Misses       1392     1394       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit b4ac776 into 2.0 Jan 5, 2024
151 checks passed
@marcotc marcotc deleted the remove-priority-config branch January 5, 2024 20:07
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants