Remove configuration for priority_sampling #3325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The configuration setting
c.tracing.priority_sampling
has been removed. This option was used to disable priority sampling, which was enabled by default.To disable priority sampling, you now have to create a custom sampler.
Motivation:
Priority sampling is the preferable way to store a sampling decision at Datadog.
Disabling it also disables features in the Datadog Agent and creates subpart reporting in the Ingestion Control page.
How to test the change?
There are unit and integration tests for all changes.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!