Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The following sampling classes have been removed from the public API:
Most custom sampling can be accomplished with a combination of Ingestion Controls and user-defined rules. This is the preferred option, as it is more maintainable and auditable than custom sampling.
If you still need a custom sampler, its API has been simplified in 2.0. See https://github.com/DataDog/dd-trace-rb/blob/2.0/docs/GettingStarted.md#custom-sampling for the new detailed requirements of a custom sampler.
Motivation:
We have made large improvements to sampling since 1.0.0 and plan to introduce new features and improvements in the near future.
The sampling changes introduced since 1.0.0 were hard to implement because almost all of the sampling classes are part of the public API. Moreover, large technical debt was introduced in order to keep the API stable while implementing such improvements. Thus, recent changes to the sampling logic have been very hard to implement correctly.
Since 1.0.0, we have introduced new ways to configure rule sampling, as well as post-ingestion sampling, which give users more maintainable options than using our custom sampling classes.
How to test the change?
There is no change in behaviour for
ddtrace
.Changes to custom samplers are documented in our public docs.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!