Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure the correct ids are serialized and propagated #3709

Merged
merged 8 commits into from
Jun 17, 2024
Merged

fix: ensure the correct ids are serialized and propagated #3709

merged 8 commits into from
Jun 17, 2024

Commits on Jun 13, 2024

  1. fix: ensure the correct ids are serialized and propagated 

    profiling test updates

fix profiling tests 2

revert

Apply suggestions from code review

lint
    @mabdinur
    mabdinur committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0712e3f View commit details
    Browse the repository at this point in the history

  2. pass id down to span_operation

    @mabdinur
    mabdinur committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    4679405 View commit details
    Browse the repository at this point in the history

  3. pack integers not strings

    @mabdinur
    mabdinur committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a70c1fc View commit details
    Browse the repository at this point in the history

  4. ensure the correct trace_id is propagated

    @mabdinur
    mabdinur committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d3e25d7 View commit details
    Browse the repository at this point in the history

  5. revert profiling test changes

    @mabdinur
    mabdinur committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    6aa2daf View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. revert changes

    @mabdinur
    mabdinur authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5c9ee72 View commit details
    Browse the repository at this point in the history

  2. update test

    @mabdinur
    mabdinur committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a22a49c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Fix matching of decoded span ids from profiles 

    Pprof decodes numeric labels as signed 64-bit values BUT as a slight
cheat both the profiler and the backend interpret them as unsigned
64-bit values so we can represent the full 64-bit values used for span
ids in traces.

But we were not accounting for this in our tests, so the decoded pprofs
we use for testing were not matching the expected values.

I've tweaked the pprof test reading code to account for this.
    @ivoanjo
    ivoanjo committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a99f0e5 View commit details
    Browse the repository at this point in the history