Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log instructions for Lograge users #3812

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add log instructions for Lograge users #3812

merged 1 commit into from
Jul 29, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jul 26, 2024

Documents #2012

Adds documentation, with a workaround, for corrupted log lines created by the combination of Rails' ActiveSupport::TaggedLogging and lograge.

I plan on also adding dynamic code warnings for this issue.

@marcotc marcotc requested a review from a team as a code owner July 26, 2024 22:59
@github-actions github-actions bot added the docs Involves documentation label Jul 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (f72d19f) to head (5556c68).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3812   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files        1261     1261           
  Lines       75620    75620           
  Branches     3706     3706           
=======================================
+ Hits        74036    74038    +2     
+ Misses       1584     1582    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jul 26, 2024

Benchmarks

Benchmark execution time: 2024-07-26 23:27:38

Comparing candidate commit 5556c68 in PR branch lograge with baseline commit f72d19f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

@marcotc marcotc merged commit 8943001 into master Jul 29, 2024
181 checks passed
@marcotc marcotc deleted the lograge branch July 29, 2024 16:11
@github-actions github-actions bot added this to the 2.3.0 milestone Jul 29, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants