[capistrano] Add ability to use etc.getpwuid instead of etc.getlogin to get the user name
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
|
Hi @rkul Sorry for the late reply, |
gzussa
added
backward-incompatible
`getlogin()` obtains the logged-in username by looking up the current tty in `utmp` and reporting the login name found in that utmp record. If Capistrano is ran from Jenkins in the host it returns the user logged in to `pts/0`, which is not the same user as runs the Capistrano. Also Ruby docs recommends avoid using `getlogin()`: >getlogin → String >Returns the short user name of the currently logged in user. Unfortunately, it is often rather easy to fool ::getlogin. > >Avoid ::getlogin for security-related purposes. > >If ::getlogin fails, try ::getpwuid. > >See the unix manpage for getpwuid(3) for more detail. http://ruby-doc.org/stdlib-2.2.0/libdoc/etc/rdoc/Etc.html#method-c-getlogin
zippolyte
added
changelog/Added
bkabrda
previously approved these changes
Jan 30, 2020
zippolyte
changed the title
etc.getpwuid instead of etc.getlogin to get the user name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getlogin()obtains the logged-in username by looking up the current tty inutmpand reporting the login name found in that utmp record. If Capistrano is ran from Jenkins in the host it returns the user logged in topts/0, which is not the same user as runs the Capistrano. Also Ruby docs recommends avoid usinggetlogin():