Check exit code of hostname -f for failures
#219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
reviewed
Jan 30, 2020
lib/dogapi/common.rb
Outdated
| @@ -200,9 +200,12 @@ def Dogapi.find_datadog_host | |||
| @@hostname = nil | |||
|
|
|||
| def Dogapi.find_localhost | |||
| @@hostname ||= %x[hostname -f].strip | |||
| unless @@hostname | |||
| @@hostname, status = Open3.capture2("hostname", "-f", :err=>File::NULL) | |||
There was a problem hiding this comment.
do we need to strip whitespaces?
jirikuncar
previously approved these changes
Jan 30, 2020
zippolyte
added
the
changelog/Fixed
KSerrania
added a commit
to DataDog/chef-handler-datadog
that referenced
this pull request
Nov 5, 2020
Updates the dogapi gem dependency to its latest version, in particular to get DataDog/dogapi-rb#219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #57
Description of the Change
%x["hostname -f"]call doesn't necessarily raise aSystemCallError(on windows 10 notably) on failure, so additionally check for exit status code.Verification Process
manual testing on windows
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.