Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setting hostname to end of method body in order to actually return it #233

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Move setting hostname to end of method body in order to actually return it #233

merged 1 commit into from
Apr 14, 2020

Conversation

nuchi-airbnb
Copy link
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Moves the line setting @@hostname to the end of the method body.

I'd noticed that our logs included hostname "n/a". The change I made fixes it. I'm not sure why your tests don't reproduce it; I notice you already have a test for this method.

Description of the Change

See above. It's short enough that I hope an extended discussion is unnecessary.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nuchi-airbnb nuchi-airbnb requested a review from a team as a code owner April 14, 2020 01:43
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution !

@zippolyte zippolyte merged commit cc9939d into DataDog:master Apr 14, 2020
@bkabrda bkabrda added the changelog/Added Added features results into a minor version bump label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants