[CONTINT-3761] Use GBI for the internal eds-check image #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 63.10% 63.10%
=======================================
Files 41 41
Lines 3098 3098
=======================================
Hits 1955 1955
Misses 1023 1023
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
wdhif
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate the internal
extendeddaemonset-checkimage to GBI.Motivation
Security folks want all containers running on our internal infra to be based on a GBI golden base image.
Additional Notes
See DataDog/images#5091.
The idea is to use GBI for the internal image only and to keep UBI as today for the public one.
As the binary is a standalone statically-linked file, it shouldn’t make any difference.
Describe your test plan
Update the version of
extendeddaemonset-checkink8s-datadog-agent-opsand check that deployments are still working fine.