Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Validate the canary properly in e2e tests #57

Merged
merged 1 commit into from
Nov 3, 2020
Merged

[e2e] Validate the canary properly in e2e tests #57

merged 1 commit into from
Nov 3, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Use the annotation extendeddaemonset.datadoghq.com/canary-valid to validate the canary in e2e tests instead of forcing the CR status values

Motivation

Fix flaky test

@ahmed-mez ahmed-mez added bug Something isn't working component/controller labels Nov 3, 2020
@ahmed-mez ahmed-mez added this to the v0.4 milestone Nov 3, 2020
@ahmed-mez ahmed-mez requested a review from a team as a code owner November 3, 2020 10:22
github-actions[bot]
github-actions bot approved these changes Nov 3, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes Nov 3, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes Nov 3, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@ahmed-mez ahmed-mez merged commit a8d38a8 into master Nov 3, 2020
@ahmed-mez ahmed-mez deleted the ahmed-mez/flaky-e2e branch November 3, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@L3n41c L3n41c L3n41c approved these changes

Assignees
No one assigned
Labels
bug Something isn't working component/controller
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmed-mez @L3n41c