[Fix] Make sure the ERS only handles defaulted EDS CR #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ahmed-mez
commented
Dec 24, 2020
Comment on lines
-35
to
-37
| if dd.Spec.Strategy.ReconcileFrequency == nil { | ||
| return false | ||
| } |
There was a problem hiding this comment.
This is duplicated (see below in this function)
Codecov Report
@@ Coverage Diff @@
## v0.5 #71 +/- ##
=======================================
Coverage ? 31.93%
=======================================
Files ? 41
Lines ? 2918
Branches ? 0
=======================================
Hits ? 932
Misses ? 1897
Partials ? 89
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
clamoriniere
pushed a commit
that referenced
this pull request
Jan 4, 2021
clamoriniere
pushed a commit
that referenced
this pull request
Jan 4, 2021
clamoriniere
pushed a commit
that referenced
this pull request
Jan 19, 2021
clamoriniere
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
By design, the ERS controller can receive requests before the EDS controller defaults the CR.
This PR adds safeguard against nil pointers when accessing CR fields (e.g
Spec.Strategy.ReconcileFrequency.Duration) in the ERS controller.Additional Notes
Related to #65
Describe your test plan
Same as #65
the CR is created.
The controller should update the spec.strategy to add it back.
Didn't override a value provided by the user.