Add shareprocessns parameter #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clamoriniere
reviewed
Mar 1, 2022
There was a problem hiding this comment.
Hi @swarren83
Thank you for this contribution. The need is legit, but for backward compatibility it makes sens to set the default values to false.
Could you please make this change and we will be able to merge this PR. 🙇
clamoriniere
added
chart/datadog
|
@clamoriniere, Thank you for the review. I have made the change to the default value. It looks like there is a conflict with the changelog. Will you be able to resolve this or how would you like me to resolve the conflict? |
clamoriniere
reviewed
Mar 1, 2022
added 6 commits
March 1, 2022 09:33
Enables process namespace sharing on cluster checks, cluster agents, and agents.
|
@clamoriniere I have the changes ready. Are you okay with a force push? |
yes no problem |
swarren83
force-pushed
the
add-shareprocessns-parameter
branch
from
ba346c3
to
d5581ed
Compare
|
@clamoriniere All done. |
clamoriniere
approved these changes
Mar 1, 2022
|
@swarren83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables process namespace sharing on cluster checks, cluster agents, and
agents.
What this PR does / why we need it:
Provides helm parameters to toggle
shareProcessNamespaceon or off.Special notes for your reviewer:
It is a CIS/PSP best practice to disable process namespace sharing.
Checklist
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md