Enforcing clustername maximum helm limit #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
force-pushed
the
nnguyen/increase-limit
branch
4 times, most recently
from
d423232
to
2484d16
Compare
nammn
force-pushed
the
nnguyen/increase-limit
branch
from
366d34b
to
19b65ec
Compare
nammn
changed the title
nammn
pushed a commit
to DataDog/documentation
that referenced
this pull request
Oct 30, 2020
With the helm update: DataDog/helm-charts#73 `cluster-name` in the helm chart can have a length of up to 80.
3 tasks
clamoriniere
reviewed
Nov 3, 2020
clamoriniere
added
the
chart/datadog
|
@nammn |
clamoriniere
approved these changes
Nov 3, 2020
nammn
force-pushed
the
nnguyen/increase-limit
branch
from
09c078c
to
ee0b9e1
Compare
nammn
force-pushed
the
nnguyen/increase-limit
branch
from
ee0b9e1
to
fceb91b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After merging DataDog/datadog-agent#6400 we decided to increase the enforced limits of 40 characters to 80.
This PR addresses this by enforcing an overall limit of 80 characters because with HELM we cannot make sure that
hostname+cluster-name< 255. With the limit of 80 we can catch most of the cases.Additionally, we can remove the enforcement of parts being maximum 40 chars:
<part>.<part>Special notes for your reviewer:
cluster-agent-values.yamlcluster-agent-values.yamlto be higher than 81 charswill throw the updated exception.
Feel free to change the values to match cases (multiple dots, longer than 80 char, parts being longer than 80 chars ect.)
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas beed updatedREADME.md