New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLINT-366] Adding glance image up and size metrics #17454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Test Results 5 files 5 suites 2m 17s ⏱️ Results for commit 5a22ccb. ♻️ This comment has been updated with latest results. |
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
rahulkaukuntla
changed the title
[PLINT-366] Adding glance image up and bytes metrics
[PLINT-366] Adding glance image up metrics
Apr 26, 2024
rahulkaukuntla
changed the title
[PLINT-366] Adding glance image up metrics
[PLINT-366] Adding glance image up and size metrics
Apr 26, 2024
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
openstack_controller/datadog_checks/openstack_controller/metrics.py
Outdated
Show resolved
Hide resolved
openstack_controller/datadog_checks/openstack_controller/metrics.py
Outdated
Show resolved
Hide resolved
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
openstack_controller/datadog_checks/openstack_controller/components/image.py
Outdated
Show resolved
Hide resolved
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
jose-manuel-almaza
approved these changes
Apr 29, 2024
rahulkaukuntla
added a commit
that referenced
this pull request
May 1, 2024
* [PLINT-366] Adding glance image up and size metrics (#17454) * adding metric openstack.glance.image.up Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding metric openstack.glance.image.bytes Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding image id as a tag Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * lint Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * removing openstack.glance.image.bytes Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding openstack.glance.image.size Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * removing redundant disable glance metrics test Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * implementing suggestions Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * addressing more comments Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * [PLINT-374] Adding glance image task metrics (#17477) * adding metric openstack.glance.image.up Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding metric openstack.glance.image.bytes Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding image id as a tag Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * lint Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * removing openstack.glance.image.bytes Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding openstack.glance.image.size Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding openstack.glance.image.task.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding another image to test Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding a test where tasks is specifically disabled Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * fixing metadata.csv description Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * [PLINT-376] Adding glance image member metrics (#17487) * adding metric openstack.glance.image.member.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * testing member metrics Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * added a changelog Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * fixed changelog number Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rahulkaukuntla rahul.kaukuntla@datadoghq.com
What does this PR do?
Adding openstack.glance.image.up openstack.glance.image.size metrics
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged