Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new glance metrics into master #17492

Merged
merged 5 commits into from
May 1, 2024
Merged

Conversation

rahulkaukuntla
Copy link
Contributor

What does this PR do?

Merge new glance metrics into master.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

* adding metric openstack.glance.image.up

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding metric openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding image id as a tag

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* lint

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* removing openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding openstack.glance.image.size

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* removing redundant disable glance metrics test

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* implementing suggestions

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* addressing more comments

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
* adding metric openstack.glance.image.up

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding metric openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding image id as a tag

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* lint

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* removing openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding openstack.glance.image.size

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding openstack.glance.image.task.count

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding another image to test

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding a test where tasks is specifically disabled

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* fixing metadata.csv description

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
* adding metric openstack.glance.image.member.count

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* testing member metrics

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
@rahulkaukuntla rahulkaukuntla marked this pull request as ready for review May 1, 2024 15:04
@rahulkaukuntla rahulkaukuntla requested review from a team as code owners May 1, 2024 15:04
Copy link

github-actions bot commented May 1, 2024

Test Results

    5 files    5 suites   2m 28s ⏱️
  516 tests 516 ✅   0 💤 0 ❌
1 552 runs  978 ✅ 574 💤 0 ❌

Results for commit 273f9dc.

@rahulkaukuntla rahulkaukuntla merged commit b493c8f into master May 1, 2024
45 of 46 checks passed
@rahulkaukuntla rahulkaukuntla deleted the rahul/glance-metrics branch May 1, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants