Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLINT-374] Adding glance image task metrics #17477

Merged
merged 11 commits into from
Apr 30, 2024

Conversation

rahulkaukuntla
Copy link
Contributor

What does this PR do?

Adding the openstack.glance.image.task.count metric

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Copy link

github-actions bot commented Apr 29, 2024

Test Results

    5 files    5 suites   2m 12s ⏱️
  497 tests 497 ✅   0 💤 0 ❌
1 495 runs  940 ✅ 555 💤 0 ❌

Results for commit 4172f97.

♻️ This comment has been updated with latest results.

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
@rahulkaukuntla rahulkaukuntla merged commit f8efe67 into rahul/glance-metrics Apr 30, 2024
17 checks passed
@rahulkaukuntla rahulkaukuntla deleted the rahul/glance-tasks branch April 30, 2024 13:47
rahulkaukuntla added a commit that referenced this pull request May 1, 2024
* [PLINT-366] Adding glance image up and size metrics (#17454)

* adding metric openstack.glance.image.up

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding metric openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding image id as a tag

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* lint

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* removing openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding openstack.glance.image.size

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* removing redundant disable glance metrics test

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* implementing suggestions

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* addressing more comments

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* [PLINT-374] Adding glance image task metrics (#17477)

* adding metric openstack.glance.image.up

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding metric openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding image id as a tag

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* lint

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* removing openstack.glance.image.bytes

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding openstack.glance.image.size

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding openstack.glance.image.task.count

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding another image to test

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* adding a test where tasks is specifically disabled

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* fixing metadata.csv description

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* [PLINT-376] Adding glance image member metrics (#17487)

* adding metric openstack.glance.image.member.count

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* testing member metrics

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* added a changelog

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

* fixed changelog number

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>

---------

Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants