Fix version metadata submitted twice #5325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related: #4818, #5144, #5252
The issues:
The version metadata might be submitted twice
We log
Cannot parse the complete Apache version from %s.
instead ofCannot parse the complete Apache version from <VERSION>.
Fix version metadata submitted twice when retrying with
?auto
. We should return, when callingself.check
recursively (note: we should avoid making recursive call if possible, it's error prone).This PR also includes:
self.log.info("Cannot parse the complete Apache version from %s.", value)
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached